First proposal for US Sensors #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic definition for use of US sensors. New detections and additional information for detected objects
carsten-kuebler
added
the
FeatureRequest
Contributor
Author
|
@CarloVanDriestenBMW Figures will be updated to .svg figures. |
ghost
suggested changes
Dec 10, 2018
osi_featuredata.proto
Outdated
|
|
||
| // Beginning blockage, sensor specific for front radar | ||
| // | ||
| EXTENDED_QUALIFIER_BEBINNING_BLOCKAGE = 12; |
osi_featuredata.proto
Outdated
| optional Identifier sensor_id = 7; | ||
|
|
||
| // The extended qualifier describes the reason (not the effect) why the | ||
| // event data qualifier \c #data_qualifier is reduced or not available. |
There was a problem hiding this comment.
[...] event data, indicated by the qualifier \c # data_qualifier, is reduced or not available.
osi_featuredata.proto
Outdated
| // The extended qualifier describes the reason (not the effect) why the | ||
| // event data qualifier \c #data_qualifier is reduced or not available. | ||
| // | ||
| // \note required for USS |
There was a problem hiding this comment.
Capital letter at the beginning and dot at the end? Please check all comments.
Contributor
Author
There was a problem hiding this comment.
I removed the note.
osi_featuredata.proto
Outdated
|
|
||
| // | ||
| // Extended qualifier describes the reason (not the effect) why the event | ||
| // data qualifier \c #data_qualifier is reduced or not available. |
osi_featuredata.proto
Outdated
| // | ||
| EXTENDED_QUALIFIER_OTHER = 1; | ||
|
|
||
| // Normal operation mode |
osi_sensorspecific.proto
Outdated
| // | ||
| optional TrilaterationStatus trilateration_status = 3; | ||
|
|
||
| // Describes the general moving direction of the feature. |
osi_sensorspecific.proto
Outdated
| // | ||
| optional Trend trend = 4; | ||
|
|
||
| // Ultrasonic signalway. Snder to receiver. |
osi_sensorspecific.proto
Outdated
| // UltrasonicDetection. \c UltrasonicDetection refer to DetectedXXX by \c | ||
| // UltrasonicDetection::object_id. | ||
| // | ||
| repeated Signalway singalway = 5; |
osi_sensorspecific.proto
Outdated
| // | ||
| TRILATERATION_STATUS_OTHER = 1; | ||
|
|
||
| // No trilateration used |
osi_sensorspecific.proto
Outdated
| // | ||
| TREND_CONSTANT_APPROACHING = 2; | ||
|
|
||
| // \note There is no definition |
There was a problem hiding this comment.
really? Please get in contact with the one who requested this property to get a definition.
Remove Typos. Improve Documentation
Vector - images may be to large :-)
Small figures for documentation
Insert .svg s and add some Documentation
ghost
approved these changes
Dec 14, 2018
Update Trend Definiton
Contributor
Author
|
@CarloVanDriestenBMW Update Trend definiton |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic definition for use of US sensors. New detections and additional information for detected objects