Skip to content

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Feb 5, 2020

Reference to a related issue in the repository

Resolves #372.

Add a description

This PR fixes the appending of int values to the message_offsets list. I also add a destructor method to close the opened file correctly after usage.

Mention a member

@jdsika review and merge. Thanks.

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@vkresch vkresch self-assigned this Feb 11, 2020
@vkresch vkresch added Bug Problems in the build system, build scripts, etc or faults in the interface. Quality Quality improvements. labels Feb 11, 2020
@jdsika jdsika added this to the v3.1.3 milestone Feb 12, 2020
@jdsika jdsika merged commit a527f86 into master Feb 12, 2020
@pmai pmai deleted the fix-message-offset branch April 27, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Problems in the build system, build scripts, etc or faults in the interface. Quality Quality improvements.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python OSITrace message_offset contains actual messages instead of lengths

3 participants