Skip to content

Conversation

@vkresch
Copy link
Contributor

@vkresch vkresch commented Feb 18, 2020

Reference to a related issue in the repository

Resolves #373

Add a description

Adding documentation for a best practice naming convention for trace files. The real implementation of the validation part can be in future performed by the OSI-Validator.

Mention a member

@jdsika review pls :) and add you custom info if needed

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@vkresch vkresch added the Documentation Everything which impacts the quality of the documentation and guidelines. label Feb 18, 2020
@vkresch vkresch self-assigned this Feb 18, 2020
@jdsika jdsika added this to the v3.1.3 milestone Feb 18, 2020
Copy link
Contributor

@jdsika jdsika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdsika jdsika merged commit c287831 into master Feb 18, 2020
@pmai pmai deleted the file-naming branch April 27, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Everything which impacts the quality of the documentation and guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Header suggestion for osi files

3 participants