Skip to content

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Feb 19, 2020

This resolves #346, by reserving all field numbers above 10000 for extensions. Since the extension mechanism of proto2 is not available in proto3, this is currently only fixed in the documentation, and will be taken into the conventions documentation prior to release.

Check the checklist

  • My code and comments follow the style guidelines and contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

@pmai pmai added this to the v3.2.0 milestone Feb 19, 2020
@pmai pmai requested review from jdsika and vkresch February 19, 2020 11:07
@pmai pmai self-assigned this Feb 19, 2020
@jdsika jdsika removed the request for review from vkresch February 19, 2020 11:50
@jdsika jdsika added the FeatureRequest Proposals which enhance the interface or add additional features. label Feb 19, 2020
@pmai pmai merged commit 77fbf54 into OpenSimulationInterface:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FeatureRequest Proposals which enhance the interface or add additional features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensions in OSI for custom fields

2 participants