Skip to content

Conversation

@yanqd0
Copy link
Contributor

@yanqd0 yanqd0 commented Sep 8, 2021

Signed-off-by: Yan QiDong yanqd0@outlook.com

2 lines are added to .gitignore.

  • osi3/, this is missing after pip install . or python setup.py develop is executed. The python package name has changed from osi to osi3 for a long time.
  • pyproject.toml, this file will be generated when this project is used with pipenv.

This is a general, simple change. It is helpful for me, maybe also for others.


  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

I don't know which reviewer should be assigned to. An ownership table may be helpful in the guidelines, which is missing and recommended.

Signed-off-by: Yan QiDong <yanqd0@outlook.com>
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just editorial changes, will merge directly.

@pmai pmai merged commit 3d276cb into OpenSimulationInterface:master Sep 8, 2021
@yanqd0 yanqd0 deleted the patch-2 branch September 9, 2021 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants