docs: native speaker review #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Schedlbauer <patrick.schedlbauer@parson-europe.com>
doc/releases/v03.02.adoc
Outdated
| * Added rules to the comments to enforce osi message validation with the https://github.com/OpenSimulationInterface/osi-validation[OSI-Validator]. | ||
| * Added the rule definitions in the rules.yml. | ||
| * Modularized testing of commenting style into python unit tests. | ||
| * Defined a standardized file format for reading trace files (*.osi). |
Contributor
There was a problem hiding this comment.
@pasched So now we fix typos in the release notes? 😃
Contributor
Author
There was a problem hiding this comment.
@stefancyliax In the heat of the review battle I just fixed them all and did not think about the agreement to leave them as they were. Please ignore these changes. ;)
Signed-off-by: Patrick Schedlbauer <patrick.schedlbauer@parson-europe.com>
stefancyliax
suggested changes
Sep 10, 2021
Signed-off-by: Stefan Cyliax <stefan.cyliax@asam.net>
stefancyliax
approved these changes
Sep 10, 2021
Contributor
stefancyliax
left a comment
stefancyliax
left a comment
There was a problem hiding this comment.
Looks fine now. Going to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.