Skip to content

Conversation

@pmai
Copy link
Contributor

@pmai pmai commented Nov 5, 2025

Modernize CMake infrastructure, including suggestions by @doganulus

@pmai pmai self-assigned this Nov 5, 2025
@doganulus
Copy link

Hi @pmai, thank you for moving this issue here.

One thing to be considered is CMake's FetchContent to handle dependencies such as protobuf. This would require newer CMake versions with increasing capability and features.

Can we increase the minimum CMake version to the version 3.18 (debian11) at least or even to 3.22 (ubuntu22.04).

@asadekasam asadekasam added ReadyForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok ReadyForMerge An issue that has been reviewed by CCB and can be merged and removed ReadyForCCBReview CCB will review it and change the status to ReadyForMerge if everything is ok labels Nov 6, 2025
@pmai
Copy link
Contributor Author

pmai commented Nov 6, 2025

One thing to be considered is CMake's FetchContent to handle dependencies such as protobuf. This would require newer CMake versions with increasing capability and features.

Can we increase the minimum CMake version to the version 3.18 (debian11) at least or even to 3.22 (ubuntu22.04).

For this release cycle we are not looking at FetchContent as a way to handle dependencies, as vcpkg and other package managers work better for cross-platform needs for us. If we would add FetchContent support we'd likely need 3.24 or higher at a minimum, so that the FetchContent would only serve as a fallback (constant changes in e.g. packaging and build needs in protobuf does not make us likely to want to interface more directly with them going forward).

@pmai pmai merged commit 21fec75 into main Nov 6, 2025
6 checks passed
@pmai pmai deleted the feature/cmake-modernisation branch November 6, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReadyForMerge An issue that has been reviewed by CCB and can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants