Skip to content

To v0.3.10; Fix for issue with: omv all -V --engine=jNeuroML_NEURON #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2025
Merged

To v0.3.10; Fix for issue with: omv all -V --engine=jNeuroML_NEURON #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0456e0
chore: bump dev to 0.3.10
sanjayankur31 Jul 17, 2025
3a33513
Add test on issue with: omv all -V --engine=jNeuroML_NEURON
pgleeson Jul 18, 2025
97e27e9
Add fix
pgleeson Jul 18, 2025
e877421
Merge pull request #146 from OpenSourceBrain/test_jnml
pgleeson Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci_versions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- name: Run simple OMV tests
run: |
omv install pyNeuroML
omv all -V --engine=jNeuroML_NEURON
omv test -V utilities/tests/.test.exIzh.jnmlnetpyne.omt


Expand Down
2 changes: 1 addition & 1 deletion omv/engines/jneuroml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def get_environment():
if "JNML_HOME" in os.environ:
jnmlhome = os.environ["JNML_HOME"]
elif shutil.which(JNeuroMLEngine.e_name) is not None:
jnmlhome = Path(shutil.which(JNeuroMLEngine.e_name)).parent
jnmlhome = str(Path(shutil.which(JNeuroMLEngine.e_name)).parent)
else:
jnmlhome = ""

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = OSBModelValidation
version = 0.3.9
version = 0.3.10
author = Boris Marin, Padraig Gleeson
author_email = borismarin@gmail.com
url = https://github.com/OpenSourceBrain/osb-model-validation
Expand Down
Loading