Fix Payroll Tax + Income Tax buttons on difference table#648
Merged
britthard merged 3 commits intoospc-org:masterfrom Sep 18, 2017
Merged
Fix Payroll Tax + Income Tax buttons on difference table#648britthard merged 3 commits intoospc-org:masterfrom
britthard merged 3 commits intoospc-org:masterfrom
Conversation
Contributor
|
@GoFroggyRun said:
What you describe as the new behavior (showing no results when both the buttons are off) sounds just fine with me. I wouldn't spend any more time on trying to "come up with a fix for this". Thanks for the quick attention to this bug report. I'm looking forward to the next version of TaxBrain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug reported in #644.
Before this PR, when payroll tax is ON and income tax is OFF, the difference table will show combined taxes; when payroll tax is ON and income tax is ON, the difference table will show payroll taxes. Both cases are incorrect.
The fix in this PR assigns proper data to each button so that:
This PR also changes the two buttons' names from "Payroll" and "Income" to "Payroll Tax" and "Income Tax", as requested in #644 .
However, turning OFF the two buttons, namely "Payroll Tax" and "Income Tax", are still allowed. I have not come up with a fix for this.
@brittainhard Could you review?
cc @martinholmer @MattHJensen