Labels and titles dynamically update and initial loading bug fixed#742
Merged
hdoupe merged 1 commit intoospc-org:masterfrom Nov 21, 2017
Merged
Labels and titles dynamically update and initial loading bug fixed#742hdoupe merged 1 commit intoospc-org:masterfrom
hdoupe merged 1 commit intoospc-org:masterfrom
Conversation
Collaborator
|
Thanks @hayleefay. I'm reviewing this now. |
Collaborator
|
@hayleefay I merged the master branch into your branch and reset the environment which moved your branch to a newer version of taxcalc. I then received the following error when I tried to do a run: Here's the traceback from the log: This could be an error on my end if my puf version is off, but I just downloaded a clean copy. So, I'm not sure how that would happen. |
Collaborator
|
@hayleefay this looks good. The problems I listed above were on my end. Sorry about that. Thanks for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes issue #728 by correcting the initial loading values of the assets shown in the hover-over and dynamically updating the title of the plots and the x-axis label.