Skip to content

Small changes to .gitignore and install script#810

Merged
hdoupe merged 1 commit intoospc-org:masterfrom
codekansas:master
Jan 27, 2018
Merged

Small changes to .gitignore and install script#810
hdoupe merged 1 commit intoospc-org:masterfrom
codekansas:master

Conversation

@codekansas
Copy link
Copy Markdown
Contributor

Explanation:

  • .DS_Store - Useless file created by Mac file browser
  • .egg-info - Created when doing pip install
  • staticfiles - Migrated staticfiles, should probably be ignored
  • pip install -e . - Safer / more consistent version of python setup.py develop

I talked to @hdoupe about my regular schedule now so expect commits around this time MWF/Sat/Sun.

@hdoupe
Copy link
Copy Markdown
Collaborator

hdoupe commented Jan 23, 2018

Thanks for the contribution @codekansas. We've always kept the staticfiles in the repo, and I was never really sure why. @GoFroggyRun is there a back-story for this? I just want to make sure that they weren't added as some Heroku work around or something.

@GoFroggyRun
Copy link
Copy Markdown
Contributor

@hdoupe I'm not sure about staticfiles either: they were there before I worked on Policy Brain repo. @martinholmer had similar concern before, but we didn't get any answer from Continuum.

@hdoupe
Copy link
Copy Markdown
Collaborator

hdoupe commented Jan 23, 2018

@GoFroggyRun Ok, thanks. I think that we should just remove them. If there's a problem for some reason, then we can add them back.

@codekansas
Copy link
Copy Markdown
Contributor Author

@hdoupe ping

@hdoupe
Copy link
Copy Markdown
Collaborator

hdoupe commented Jan 27, 2018

Thanks for the contribution @codekansas

@hdoupe hdoupe merged commit 39867ad into ospc-org:master Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants