[WIP] Add special HTML pages for when a model result is not found or is incompatible#874
Merged
hdoupe merged 4 commits intoospc-org:masterfrom Mar 28, 2018
Merged
Conversation
Contributor
Author
|
Here's a preview for TB version: @hdoupe could you take a look at these pages? Feel free to modify the content if you'd like. Do you find these pages sufficient for you to render in |
Contributor
Author
Collaborator
|
@GoFroggyRun these look good. I think we can go ahead and merge this. I'll update the back-end so that these pages are rendered on exceptions. I'll also tweak the language some. Thanks for the quick response on this PR. I think it does make sense to break up the headers. Would you mind opening a separate PR to do this? There's a lot of apps referencing code in other apps in both in the front-end and in the back-end. I think it's a good idea to draw a clear line between the different apps and pull the shared code into a central place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR tries to close #869. Two HTML pages are added to TB and CCC respectively, where the content of the page suggest an option to re-create outdated results.