Update CI to Swift 5.10

Author: Kyle-Ye

.github/workflows/compatibility_tests.yml

@@ -13,11 +13,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: macos-13
-            xcode-version: "15.2"   # Swift 5.9.2
           - os: macos-14
-            xcode-version: "15.2"   # Swift 5.9.2
+            xcode-version: "15.3"   # Swift 5.10
     runs-on: ${{ matrix.os }}
+    env:
+      OPENGRAPH_WERROR: 1
+      OPENGRAPH_SWIFT_TESTING: 1
+      OPENGRAPH_ATTRIBUTEGRAPH: 1
+      OPENGRAPH_COMPATIBILITY_TEST: 1
     steps:
       - uses: actions/checkout@v4
       - name: Setup Xcode
@@ -26,19 +29,13 @@ jobs:
           xcode-version: ${{ matrix.xcode-version }}
       - name: Swift version
         run: swift --version
-      - name: Run tests against Apple's AttributeGraph on macOS
+      - name: Run tests against Apple's AttributeGraph on macOS via SwiftPM
         run: |
           swift test \
             --build-path .build-compatibility-test-debug
-        env:
-          OPENGRAPH_ATTRIBUTEGRAPH: 1
-          OPENGRAPH_COMPATIBILITY_TEST: 1 
-      # FIXME: macOS 13 CI issue. Can't reproduce on macOS 14 locally
-      # - name: Run tests against Apple's AttributeGraph on macOS
-      #   run: |
-      #     xcodebuild test \
-      #       -scheme OpenGraph-Package \
-      #       -sdk macosx \
-      #       -destination "platform=macOS"
-      #   env:
-      #     OPENGRAPH_COMPATIBILITY_TEST: 1 
+      - name: Run tests against Apple's AttributeGraph on macOS via Xcode
+        run: |
+          xcodebuild test \
+            -scheme OpenGraph-Package \
+            -sdk macosx \
+            -destination "platform=macOS"

.github/workflows/ios.yml

@@ -13,12 +13,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          # macOS 13 CI issue: "/Users/runner/work/_temp/3a207233-d293-4e92-9dd3-b83f7ccd4597.sh: line 7:  2698 Segmentation fault: 11  xcodebuild build"
-          # - os: macos-13
-            # xcode-version: "15.2"   # Swift 5.9.2
           - os: macos-14
-            xcode-version: "15.2"   # Swift 5.9.2
+            xcode-version: "15.3"   # Swift 5.10
     runs-on: ${{ matrix.os }}
+    env:
+      OPENGRAPH_WERROR: 1
+      OPENGRAPH_SWIFT_TESTING: 1
+      OPENGRAPH_ATTRIBUTEGRAPH: 0
+      OPENGRAPH_COMPATIBILITY_TEST: 0
     steps:
       - uses: actions/checkout@v4
       - name: Setup Xcode

.github/workflows/macos.yml

@@ -13,11 +13,14 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: macos-13
-            xcode-version: "15.2"   # Swift 5.9.2
           - os: macos-14
-            xcode-version: "15.2"   # Swift 5.9.2
+            xcode-version: "15.3"   # Swift 5.10
     runs-on: ${{ matrix.os }}
+    env:
+      OPENGRAPH_WERROR: 1
+      OPENGRAPH_SWIFT_TESTING: 1
+      OPENGRAPH_ATTRIBUTEGRAPH: 0
+      OPENGRAPH_COMPATIBILITY_TEST: 0
     steps:
       - uses: actions/checkout@v4
       - name: Setup Xcode
@@ -30,7 +33,6 @@ jobs:
         run: |
           swift test \
             -c debug \
-            -Xswiftc -warnings-as-errors \
             --enable-code-coverage \
             --build-path .build-test-debug
           xcrun llvm-cov show \
@@ -41,7 +43,6 @@ jobs:
         run: |
           swift test \
             -c release \
-            -Xswiftc -warnings-as-errors \
             --enable-code-coverage \
             --build-path .build-test-release
       - uses: codecov/codecov-action@v3

.github/workflows/ubuntu.yml

@@ -12,8 +12,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        swift_version: ["5.9.2"]
+        swift_version: ["5.10"]
     runs-on: ubuntu-22.04
+    env:
+      OPENGRAPH_WERROR: 1
+      OPENGRAPH_SWIFT_TESTING: 1
+      OPENGRAPH_ATTRIBUTEGRAPH: 0
+      OPENGRAPH_COMPATIBILITY_TEST: 0
     container: swift:${{ matrix.swift_version }}-jammy
     steps:
       - uses: actions/checkout@v4
@@ -24,7 +29,6 @@ jobs:
         run: |
           swift test \
             -c debug \
-            -Xswiftc -warnings-as-errors \
             --enable-code-coverage \
             --build-path .build-test-debug
           llvm-cov show \
@@ -35,7 +39,6 @@ jobs:
         run: |
           swift test \
             -c release \
-            -Xswiftc -warnings-as-errors \
             --build-path .build-test-release
       - uses: codecov/codecov-action@v3
         with:

.github/workflows/wasm.yml

@@ -12,14 +12,19 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        swift_version: ["5.9.1"]
+        swift_version: ["5.9.1-RELEASE", "5.10-SNAPSHOT-2024-03-14-a"]
         os: [ubuntu-22.04]
     runs-on: ${{ matrix.os }}
+    env:
+      OPENGRAPH_WERROR: 1
+      OPENGRAPH_SWIFT_TESTING: 0
+      OPENGRAPH_ATTRIBUTEGRAPH: 0
+      OPENGRAPH_COMPATIBILITY_TEST: 0
     steps:
       - uses: actions/checkout@v4
       - uses: swiftwasm/setup-swiftwasm@v1
         with:
-          swift-version: wasm-${{ matrix.swift_version }}-RELEASE
+          swift-version: wasm-${{ matrix.swift_version }}
       - name: build
         run: |
           swift build --triple wasm32-unknown-wasi

Package.resolved

@@ -1,4 +1,4 @@
-// swift-tools-version: 5.9
+// swift-tools-version: 5.10
 // The swift-tools-version declares the minimum version of Swift required to build this package.
 
 import Foundation
@@ -18,10 +18,11 @@ func envEnable(_ key: String, default defaultValue: Bool = false) -> Bool {
 }
 
 let isXcodeEnv = Context.environment["__CFBundleIdentifier"] == "com.apple.dt.Xcode"
+let development = envEnable("OPENGRAPH_DEVELOPMENT", default: false)
 
 var sharedSwiftSettings: [SwiftSetting] = []
 
-let warningsAsErrorsCondition = envEnable("OPENGRAPH_WERROR", default: isXcodeEnv)
+let warningsAsErrorsCondition = envEnable("OPENGRAPH_WERROR", default: isXcodeEnv && development)
 if warningsAsErrorsCondition {
     sharedSwiftSettings.append(.unsafeFlags(["-warnings-as-errors"]))
 }
@@ -125,8 +126,7 @@ if attributeGraphCondition {
 let swiftTestingCondition = envEnable("OPENGRAPH_SWIFT_TESTING", default: true)
 if swiftTestingCondition {
     package.dependencies.append(
-        // Fix it to be 0.3.0 before we bump to Swift 5.10
-        .package(url: "https://github.com/apple/swift-testing", exact: "0.3.0")
+        .package(url: "https://github.com/apple/swift-testing", exact: "0.6.0")
     )
     openGraphTestTarget.dependencies.append(
         .product(name: "Testing", package: "swift-testing")