Skip to content

Add GestureDebug.ChildrenBox and implement GesturePhase.descriptionWithoutValue #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2025
Merged

Add GestureDebug.ChildrenBox and implement GesturePhase.descriptionWithoutValue #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions Sources/OpenSwiftUICore/Event/Gesture/GestureDebug.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ package enum GestureDebug {
case combiner
}

private enum ChildrenBox {
indirect case value(Data.Children)
}

package struct Data {
package var kind: GestureDebug.Kind
package var type: any Any.Type
Expand All @@ -28,7 +32,7 @@ package enum GestureDebug {
package var resetSeed: UInt32
package var frame: CGRect
package var properties: GestureDebug.Properties
// private var childrenBox: GestureDebug.ChildrenBox
private var childrenBox: GestureDebug.ChildrenBox

package typealias Children = ArrayWith2Inline<GestureDebug.Data>

Expand All @@ -45,6 +49,7 @@ package enum GestureDebug {
resetSeed = 0
frame = .zero
properties = .init()
childrenBox = .value([]) // FIXME
}

package init(
Expand Down Expand Up @@ -169,17 +174,26 @@ extension _GestureOutputs {
}
}

@_spi(ForSwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
extension GesturePhase {
@_spi(ForSwiftUIOnly)
package var descriptionWithoutValue: String {
@_spi(ForSwiftUIOnly)
get { _openSwiftUIUnimplementedFailure() }
switch self {
case let .possible(value): value == nil ? "" : "possible(some)"
case .active: "active"
case .ended: "ended"
case .failed: "failed"
}
}
}

extension GestureDebug.Data {
package func printTree() {
_openSwiftUIUnimplementedFailure()
}

private typealias Indent = String

private func printSubtree(parent: GestureDebug.Data?, indent: Indent) {
_openSwiftUIUnimplementedFailure()
}
}
12 changes: 6 additions & 6 deletions Sources/OpenSwiftUICore/Event/Gesture/GesturePhase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

// MARK: - GesturePhase [6.5.4]

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
@available(OpenSwiftUI_v6_0, *)
public enum GesturePhase<Wrapped> {
case possible(Wrapped?)
Expand All @@ -15,14 +15,14 @@ public enum GesturePhase<Wrapped> {
case failed
}

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
@available(*, unavailable)
extension GesturePhase: Sendable {}

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
extension GesturePhase: Equatable where Wrapped: Equatable {}

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
extension GesturePhase {
package var unwrapped: Wrapped? {
switch self {
Expand Down Expand Up @@ -84,14 +84,14 @@ extension GesturePhase {

// MARK: - GesturePhase + Defaultable [6.5.4]

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
extension GesturePhase: Defaultable {
package static var defaultValue: GesturePhase<Wrapped> { .failed }
}

// MARK: - GestureCategory + Defaultable [6.5.4]

@_spi(ForOnlySwiftUIOnly)
@_spi(ForOpenSwiftUIOnly)
extension GestureCategory: Defaultable {
package static var defaultValue: GestureCategory { .magnify }
}
2 changes: 1 addition & 1 deletion Sources/OpenSwiftUICore/Event/Responder/ViewResponder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ open class ViewResponder: ResponderNode, CustomStringConvertible/*, CustomRecurs

final package weak var parent: ViewResponder? = nil {
willSet {
guard let parent, newValue == nil else {
guard parent != nil, newValue == nil else {
return
}
guard let host, let eventGraphHost = host.as(EventGraphHost.self) else {
Expand Down