Skip to content

Fix typo in needsRender property #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2025
Merged

Fix typo in needsRender property #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/OpenSwiftUI/Integration/Hosting/UIKit/View/UIHostingView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,7 +785,7 @@ extension _UIHostingView: TestHost {

public func _renderForTest(interval: Double) {
func shouldContinue() -> Bool {
if propertiesNeedingUpdate == [], !CoreTesting.needRender {
if propertiesNeedingUpdate == [], !CoreTesting.needsRender {
false
} else {
times >= 0
Expand All @@ -796,15 +796,15 @@ extension _UIHostingView: TestHost {
var times = 16
repeat {
times -= 1
CoreTesting.needRender = false
CoreTesting.needsRender = false
updateGraph { host in
host.flushTransactions()
}
RunLoop.flushObservers()
render(targetTimestamp: nil)
CATransaction.flush()
} while shouldContinue()
CoreTesting.needRender = false
CoreTesting.needsRender = false
canAdvanceTimeAutomatically = true
}
}
Expand Down
4 changes: 2 additions & 2 deletions Sources/OpenSwiftUI/Test/ViewTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ extension _ViewTest {
let commonMode = RunLoop.Mode.common
let interval = 0.001
var times = 17
while CoreTesting.needRender || CoreTesting.neeedsRunLoopTurn {
while CoreTesting.needsRender || CoreTesting.neeedsRunLoopTurn {
// let modes = [defaultMode, commonMode]
let date = Date(timeIntervalSinceNow: interval)
if !RunLoop.current.run(mode: defaultMode, before: date) {
Expand All @@ -272,7 +272,7 @@ extension _ViewTest {
break
}
}
if CoreTesting.needRender || CoreTesting.neeedsRunLoopTurn {
if CoreTesting.needsRender || CoreTesting.neeedsRunLoopTurn {
Log.unitTests.log(level: .default, "Render or run loop turn needed after max iterations")
}
}
Expand Down
2 changes: 1 addition & 1 deletion Sources/OpenSwiftUICore/Test/CoreTesting.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
package enum CoreTesting {
package static var isRunning: Bool = false

package static var needRender: Bool = false
package static var needsRender: Bool = false

package static var neeedsRunLoopTurn: Bool {
false
Expand Down