-
Notifications
You must be signed in to change notification settings - Fork 54
Add PositionLayout #507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PositionLayout #507
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add header information and test case.
|
@Kyle-Ye I’ve added a test case, but I’m not sure where to find the correct ID for the header information. I know that private types include it, but where should I look for other types? Please let me know if I’ve missed something. |
If there is no private stuff, there is no need to state the ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have tweaked the format a little and will merge it today once the pipeline success.
By the way, if you want to implement a feature, I suggest you can create an issue first to avoid potential conflict.
|
Ok, I got it. |
No description provided.