Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 4, 2025

Summary

This PR migrates claude.yml and issue-triage.yml to use shared reusable workflows from the organization-wide github-workflows repository.

Changes

  • Updated .github/workflows/claude.yml to call the shared workflow
  • Updated .github/workflows/issue-triage.yml to call the shared workflow

Benefits

  • Reduces maintenance burden by centralizing workflow logic
  • Ensures consistency across all OpenSwiftUI organization repositories
  • Simplifies future updates to workflow behavior
  • Follows the pattern used in OpenAttributeGraph#188

Implementation

The workflows continue to trigger on the same events as before but now delegate to shared reusable workflows:

jobs:
  claude:
    uses: OpenSwiftUIProject/github-workflows/.github/workflows/claude.yml@main
    secrets: inherit

Related

@Kyle-Ye Kyle-Ye force-pushed the move-workflows-to-org branch from 8abea07 to 892d363 Compare October 4, 2025 07:30
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 4, 2025

@claude review this PR.

@claude
Copy link

claude bot commented Oct 4, 2025

Claude finished @Kyle-Ye's task —— View job


PR Review: Move shared workflows to organization repository

Summary

This PR removes two GitHub Actions workflows (claude.yml and issue-triage.yml) from this repository with the intention of moving them to a centralized organization-wide repository at OpenSwiftUIProject/github-workflows.

✅ What looks good

  1. Clean removal: Both workflow files are completely removed with no remaining references in the codebase
  2. Good documentation: The PR description clearly explains the motivation and benefits
  3. Follows established pattern: Using the swiftlang/github-workflows approach is a solid precedent
  4. Remaining workflows intact: Other CI workflows (compatibility_tests, ios, macos, ubuntu, uitests) are unaffected

⚠️ Potential concerns

  1. Organization repository verification: I cannot verify that the OpenSwiftUIProject/github-workflows repository exists and contains these workflows (access limitations). Before merging, please confirm:

    • The organization repository exists and is accessible
    • Both claude.yml and issue-triage.yml have been successfully moved there
    • The workflows are functional in the new location
  2. Missing migration step: This PR only removes the workflows but doesn't add new workflow files that reference the shared workflows. To actually use the centralized workflows, you'll need to create new workflow files that call them, such as:

    # .github/workflows/claude-shared.yml
    name: Claude Code
    on:
      issue_comment:
        types: [created]
      # ... other triggers
    
    jobs:
      claude:
        uses: OpenSwiftUIProject/github-workflows/.github/workflows/claude.yml@main
        secrets: inherit

    Without these caller workflows, the Claude and issue triage functionality will be lost from this repository.

  3. Secrets configuration: Verify that organization-level secrets are properly configured:

    • CLAUDE_CODE_OAUTH_TOKEN
    • ANTHROPIC_API_KEY
    • GITHUB_TOKEN (should be automatic)

📋 Recommendations

  1. Before merging: Add new workflow files that reference the shared workflows, or document in the PR that this will be done in a follow-up PR
  2. Test the migration: Ensure the shared workflows work correctly when called from this repository
  3. Update documentation: Consider updating README.md or adding a note about the centralized workflow location

Verdict

The removal itself is clean and correct, but this appears to be an incomplete migration. I recommend not merging until caller workflows are added to maintain the Claude Code and issue triage functionality in this repository.


Job Run | Branch: move-workflows-to-org

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.34%. Comparing base (b6d0cf0) to head (557b067).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   24.31%   24.34%   +0.02%     
==========================================
  Files         506      506              
  Lines       28979    28979              
==========================================
+ Hits         7046     7054       +8     
+ Misses      21933    21925       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Updated claude.yml and issue-triage.yml to call the organization-wide
shared workflows instead of maintaining duplicate implementations.

These workflows now reference:
https://github.com/OpenSwiftUIProject/github-workflows

This change:
- Reduces maintenance burden by centralizing workflow logic
- Ensures consistency across all OpenSwiftUI organization repositories
- Simplifies future updates to workflow behavior

The workflows continue to trigger on the same events as before but now
delegate to the shared reusable workflows maintained at the organization level.
@Kyle-Ye Kyle-Ye force-pushed the move-workflows-to-org branch from 892d363 to 557b067 Compare October 4, 2025 09:09
@Kyle-Ye Kyle-Ye changed the title Move shared workflows to organization repository Migrate to shared workflows from organization repository Oct 4, 2025
@Kyle-Ye Kyle-Ye merged commit ee10119 into main Oct 4, 2025
7 checks passed
@Kyle-Ye Kyle-Ye deleted the move-workflows-to-org branch October 4, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants