Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 7, 2025

Summary

Close #517

Changes

  • Update PlatformViewChild
    • Fix missing update call for Representable types)
    • Implement ViewRendererHost.enclosingHosts
    • Implement PlatformView.isPlatformFocusContainerHost
    • Correct signpost implementation
  • Update UnsafePointer usage

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 0% with 149 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.53%. Comparing base (5281451) to head (7473ebd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...esentable/Platform/PlatformViewRepresentable.swift 0.00% 124 Missing ⚠️
.../OpenSwiftUICore/View/Graph/ViewRendererHost.swift 0.00% 9 Missing ⚠️
.../OpenSwiftUICore/Data/Util/ScrapeableContent.swift 0.00% 6 Missing ⚠️
...tUICore/Render/RendererEffect/RendererEffect.swift 0.00% 6 Missing ⚠️
Sources/OpenSwiftUI/Event/Focus/FocusGroup.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   24.63%   24.53%   -0.11%     
==========================================
  Files         505      506       +1     
  Lines       29204    29319     +115     
==========================================
- Hits         7195     7194       -1     
- Misses      22009    22125     +116     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye changed the title Various updates and bug fixes Implement PlatformView features and ViewRendererHost improvements Oct 7, 2025
@Kyle-Ye Kyle-Ye merged commit 6eb686a into main Oct 7, 2025
9 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/update_vc branch October 7, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] ViewRepresentable's update[UI/NS]View method is not triggered properly

2 participants