Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 8, 2025

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 0% with 561 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.91%. Comparing base (5084387) to head (2a8436e).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...SwiftUICore/Layout/Dynamic/DynamicLayoutView.swift 0.00% 215 Missing ⚠️
...nSwiftUICore/Layout/Dynamic/DynamicContainer.swift 0.00% 139 Missing ⚠️
...nSwiftUICore/Layout/Dynamic/DynamicLayoutMap.swift 0.00% 69 Missing ⚠️
...ces/OpenSwiftUICore/View/Scroll/ScrollTarget.swift 0.00% 53 Missing ⚠️
...enSwiftUICore/View/Scroll/Transaction+Scroll.swift 0.00% 22 Missing ⚠️
...tUICore/View/Scroll/ScrollPosition+Modifiers.swift 0.00% 10 Missing ⚠️
...ICore/Layout/Dynamic/DynamicContainerAdaptor.swift 0.00% 9 Missing ⚠️
...iftUICore/Layout/Dynamic/DynamicViewListItem.swift 0.00% 9 Missing ⚠️
...urces/OpenSwiftUICore/View/Scroll/Scrollable.swift 0.00% 9 Missing ⚠️
...enSwiftUICore/View/Scroll/ScrollStateRequest.swift 0.00% 8 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   24.40%   23.91%   -0.50%     
==========================================
  Files         513      522       +9     
  Lines       29493    29676     +183     
==========================================
- Hits         7199     7098     -101     
- Misses      22294    22578     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 8, 2025

@claude The Ubuntu CI is failing due the missing conformance of CGRect/CGPoint to Hashable.

Such conformance is from CoreGraphcis and does not exist on Linux.

Help me propose the change needed in OpenSwiftUI/OpenCoreGraphics repo and create a PR.

@claude

This comment was marked as resolved.

@Kyle-Ye Kyle-Ye force-pushed the feature/dynamicview branch from 5e231e7 to 2a8436e Compare October 8, 2025 19:04
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 8, 2025

Fix it via OpenSwiftUIProject/OpenCoreGraphics#6

@Kyle-Ye Kyle-Ye merged commit d7c15c6 into main Oct 8, 2025
5 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/dynamicview branch October 8, 2025 19:09
@Kyle-Ye Kyle-Ye added the P0 Top priority label Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request P0 Top priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants