Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 12, 2025

Close #567

The root cause is that DynamicContainer is missing updating. So indexMap is nil.

Then DynamicLayoutViewChildGeometry will set its value to .zero.

    func updateValue() {
        guard let index = containerInfo.viewIndex(id: id), index < childGeometries.count else {
            if !hasValue {
                value = .zero
            }
            return
        }
        value = childGeometries[index]
    }

@github-actions github-actions bot added bug Something isn't working test Test related issue labels Oct 12, 2025
@github-actions github-actions bot added the P1 Medium priority label Oct 12, 2025
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.62%. Comparing base (0c0f992) to head (99dae2e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nSwiftUICore/Layout/Dynamic/DynamicContainer.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   23.61%   23.62%   +0.01%     
==========================================
  Files         525      525              
  Lines       30470    30472       +2     
==========================================
+ Hits         7195     7199       +4     
+ Misses      23275    23273       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit df0e50d into main Oct 12, 2025
8 of 9 checks passed
@Kyle-Ye Kyle-Ye deleted the k-branch-1 branch October 12, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P1 Medium priority test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DynamicView will evaluate to zero geometry

2 participants