Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Oct 12, 2025

Close #569

@github-actions github-actions bot added bug Something isn't working P2 Low priority labels Oct 12, 2025
@Kyle-Ye Kyle-Ye linked an issue Oct 12, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.59%. Comparing base (df0e50d) to head (630af9f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nSwiftUICore/Layout/Dynamic/DynamicContainer.swift 0.00% 8 Missing ⚠️
Sources/OpenSwiftUICore/View/DynamicView.swift 0.00% 6 Missing ⚠️
Sources/OpenSwiftUICore/Render/OpacityEffect.swift 0.00% 5 Missing ⚠️
Sources/OpenSwiftUICore/View/IDView.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   23.62%   23.59%   -0.03%     
==========================================
  Files         525      526       +1     
  Lines       30472    30480       +8     
==========================================
- Hits         7200     7193       -7     
- Misses      23272    23287      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 12, 2025

This is currently causing a regression on AppearanceActionModifierCompatibilityTests.idTest.

@github-actions github-actions bot added the test Test related issue label Oct 13, 2025
@Kyle-Ye
Copy link
Collaborator Author

Kyle-Ye commented Oct 13, 2025

Fixed the regression by correcting the DynamicContainerInfo.tryRemovingItem's needsTransitions check.

The default transition is opacity which should return false for AnyTransition.isIdentity while current it is returning true.

The fix is to add a plain opacity transition to make isIdentity return false.

@Kyle-Ye Kyle-Ye merged commit 28977dd into main Oct 13, 2025
9 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/idview branch October 13, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working P2 Low priority test Test related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The new IDView implementation will not trigger update when ID changes MyViewThatFitsByLayout animation example issue after a few phase

2 participants