supports nim 0.19 and latest devel #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I wrote this lib when I was learning Nim, and trying to understand how stuffs work. It is just for education purpose, glad that it helps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a warning (indentation) and an error (strings are now
nil-hostile) to make thenim@0.19(and latestdevel) compiler happy.Heads up: I noticed in your
q.nimblefile you supportnim@0.10and up. Although this change is compatible withnim@0.18and up, I really don't know if it is compatible going all the way back to0.10.Thank you kindly for this library. It works well for my light html parsing needs... also, I'm shocked at how small the codebase is. Great job.