Johnson su #216
Merged
Johnson su #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve the preprocessing and embedding layers in the
mambularpackage. The main changes involve adding a feature preprocessing dictionary to thePreprocessorclass, updating theforwardmethod in the embedding layer, and refactoring code for better readability and functionality.Preprocessing improvements:
mambular/preprocessing/preprocessor.py: Addedfeature_preprocessingparameter to allow custom preprocessing techniques for individual columns. Updated thefitmethod to use this parameter for both numerical and categorical features. [1] [2] [3] [4] [5]Embedding layer updates:
mambular/arch_utils/layer_utils/embedding_layer.py: Modified theforwardmethod to handle different dimensions of categorical embeddings and ensure they are properly processed. [1] [2]Code readability improvements:
mambular/preprocessing/preprocessor.py: Refactored various methods to improve readability, such as breaking long lines and adding parentheses for clarity. [1] [2] [3] [4] [5]mambular/utils/distributions.py: Improved readability of theforwardandcompute_lossmethods by breaking long lines and adding parentheses. [1] [2]