Update bootstrap #1845
Merged
Update bootstrap #1845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What was the old version? Do we need to worry about breaking changes? |
|
@RickMohr The old version was 3.1.1 |
|
Well, who knows about that "if"? Finding any introduced regressions in OTM would be tough. Can we (or a designer) research the safety? |
|
Well they have this in their README. I skimmed https://github.com/twbs/bootstrap/releases for versions 3.2.0-3.3.1 and didn't see any breaking changes. Looks like it's mostly bug fixes and and tiny new features, with a couple of deprecated (but not removed) features. |
|
Though I still have no intention of merging this until after we start our release process. |
maurizi
force-pushed
the
update-bootstrap
branch
from
e74470d to
e2801e8
Compare
|
Thanks, +1 |
maurizi
force-pushed
the
update-bootstrap
branch
from
e2801e8 to
7755321
Compare
maurizi
force-pushed
the
update-bootstrap
branch
from
7755321 to
82bed0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1844. Opening this as a separate PR to avoid any regressions given the imminent release.