Invalid Index - Bug Fix #895
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is not the correct fix as it changes the semantics. I have already a correct fix prepared that should be push to the OpenVPN repo in the next few days. |
Author
|
Hi Arne, thanks for taking a look at it. Yeah this was just my temporary workaround fix to help protect the next else block but I wasn't sure if there were any edge cases or code paths that might not be covered by changing the conditionals. I can close this PR, thanks again! |
Contributor
|
https://gerrit.openvpn.net/c/openvpn/+/1373 Credits to @stoops (and ZeroPath, found twice in very short time) will be added to the commit message on merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed that there is an edge case where if the session ID is not found (i==3) && it is not a hard reset then the code path will then enter into the else block with (i==TM_SIZE==3) and enter into the multi->session[i] array (session[TM_SIZE]) which is an invalid index access!