Drop puppet_connect plugin & module #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

nmburgan merged 1 commit into main from drop_puppet_connect

Mar 9, 2026

.gitignore

-Original file line number
+Diff line change
@@ Expand Up / @@ -55,7 +55,6 @@ acceptance/hosts.yaml @@
     modules/*
     !modules/aggregate
     !modules/canary
-    !modules/puppet_connect
     !modules/puppetdb_fact
     .sass-cache/
@@ Expand Down @@

.rubocop_todo.yml

-Original file line number
+Diff line change
@@ Expand Up / @@ -527,7 +527,6 @@ RSpec/NamedSubject: @@
         - 'spec/unit/plan_creator_spec.rb'
         - 'spec/unit/plugin/env_var_spec.rb'
         - 'spec/unit/plugin/prompt_spec.rb'
-        - 'spec/unit/plugin/puppet_connect_data_spec.rb'
         - 'spec/unit/transport/local_spec.rb'
         - 'spec/unit/transport/ssh/connection_spec.rb'
         - 'spec/unit/transport/ssh/exec_connection_spec.rb'
@@ Expand Down Expand Up / @@ -648,7 +647,6 @@ RSpec/StubbedMock: @@
     # Offense count: 3
     RSpec/SubjectDeclaration:
       Exclude:
-        - 'spec/unit/plugin/puppet_connect_data_spec.rb'
         - 'spec/unit/transport/ssh/connection_spec.rb'
         - 'spec/unit/transport/ssh/exec_connection_spec.rb'
@@ Expand Down @@

Puppetfile

-Original file line number
+Diff line change
@@ Expand Up / @@ -55,4 +55,3 @@ mod 'puppetlabs-yaml', '0.2.0' @@
     mod 'canary', local: true
     mod 'aggregate', local: true
     mod 'puppetdb_fact', local: true
-    mod 'puppet_connect', local: true

lib/bolt/cli.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -750,7 +750,7 @@ def execute(options) @@
         # built-in modules are installed.
         #
         private def incomplete_install?
-          builtin_module_list = %w[aggregate canary puppetdb_fact secure_env_vars puppet_connect]
+          builtin_module_list = %w[aggregate canary puppetdb_fact secure_env_vars]
           (Dir.children(Bolt::Config::Modulepath::MODULES_PATH) - builtin_module_list).empty?
         end
@@ Expand Down @@

lib/bolt/plugin.rb

-Original file line number
+Diff line change
@@ Expand Up / @@ -127,7 +127,7 @@ def boltdir @@
           end
         end
-        RUBY_PLUGINS = %w[task prompt env_var puppetdb puppet_connect_data].freeze
+        RUBY_PLUGINS = %w[task prompt env_var puppetdb].freeze
         BUILTIN_PLUGINS = %w[task terraform pkcs7 prompt vault aws_inventory puppetdb azure_inventory
                              yaml env_var gcloud_inventory].freeze
         DEFAULT_PLUGIN_HOOKS = { 'puppet_library' => { 'plugin' => 'openvox_bootstrap', 'stop_service' => true } }.freeze
@@ Expand Down Expand Up / @@ -255,9 +255,6 @@ def list_plugins @@
           hooks = KNOWN_HOOKS.map { |hook| [hook, {}] }.to_h
           @plugins.sort.each do |name, plugin|
-            # Don't show the Puppet Connect plugin for now.
-            next if name == 'puppet_connect_data'
             case plugin
             when Bolt::Plugin::Module
               plugin.hook_map.each do |hook, spec|
@@ Expand Down @@

lib/bolt/plugin/puppet_connect_data.rb

This file was deleted.

modules/puppet_connect/README.md

This file was deleted.

modules/puppet_connect/plans/test_input_data.pp

This file was deleted.

Provide feedback