yum package provider: add assumeyes to yum check-update
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenVD-be
changed the title
SvenVD-be
changed the title
SvenVD-be
force-pushed
the
SvenVD-be-patch-1
branch
from
a9293f7 to
8add25f
Compare
This solves the observed on at least RHEL8 if repo_gpgcheck=1 AND baseurl is changed (by a yumrepo resources for example) AND no other puppet package with dnf -y (assumeyes) has been run then dnf asks to re-import already imported keys (the key needs to be imported into dnf's databases, which is separate from rpm database and it is a new database per baseurl https://bugzilla.redhat.com/show_bug.cgi?id=1768206) If puppet then runs dnf check-update because of a package has ensure => latest then it fails with: Warning: Puppet::Type::Package::ProviderDnf: Could not check for updates, '/bin/dnf check-update' exited with 1 Add assumeyes to check-update, this also makes it more consistent with the other dnf commands in yum.rb which also use "-y"
SvenVD-be
force-pushed
the
SvenVD-be-patch-1
branch
from
8add25f to
6715a68
Compare
kenyon
changed the title
yum package provider: add assumeyes to yum check-update
kenyon
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the observed issue (on at least RHEL8) if repo_gpgcheck=1 AND baseurl is changed (by a yumrepo resources for example) AND no other puppet package with dnf -y (assumeyes) has been run then dnf asks to re-import already imported keys (the key needs to be imported into dnf's databases, which is separate from rpm database and it is a new database per baseurl https://bugzilla.redhat.com/show_bug.cgi?id=1768206). If puppet then runs
dnf check-updatebecause of a package hasensure => latestthen it fails with:Warning: Puppet::Type::Package::ProviderDnf: Could not check for updates, '/bin/dnf check-update' exited with 1Add assumeyes to check-update, this also makes it more consistent with the other dnf commands in yum.rb which also use "-y"