Skip to content

CI: Build gem for each PR & Move packaging checks to global config & Windows: Run one spec file per CPU core #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 23, 2025
Merged

CI: Build gem for each PR & Move packaging checks to global config & Windows: Run one spec file per CPU core #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e176cb
CI: Build gem for each PR
bastelfreak Sep 23, 2025
8db5e89
CI: Move packaging checks to global config
bastelfreak Sep 23, 2025
4864dee
Windows: Run one spec file per CPU core
bastelfreak Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions .github/workflows/checks.yml
View file
Open in desktop

This file was deleted.

32 changes: 30 additions & 2 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ jobs:
bundler-cache: true
- name: Output Ruby Environment
run: bundle env

- name: Build gem for all platforms
run: bundle exec rake pl_ci:gem_build
# Windows tests fail if the gem is in the filesystem
- name: Cleanup builds
if: runner.os == 'Windows'
run: Remove-Item -Path *.gem
- name: Run tests on Windows
if: runner.os == 'Windows'
run: |
Expand All @@ -85,7 +90,7 @@ jobs:
ruby -ropenssl -e 'puts "OpenSSL Version - #{OpenSSL::OPENSSL_VERSION}"; puts "OpenSSL Library Version - #{OpenSSL::OPENSSL_LIBRARY_VERSION}"'

# Run tests
bundle exec rake parallel:spec[2]
bundle exec rake parallel:spec

- name: Run tests on Linux
if: runner.os == 'Linux'
Expand All @@ -102,11 +107,34 @@ jobs:

bundle exec rake parallel:spec

rake_checks:
name: AIO Package Rake Checks
runs-on: ubuntu-24.04
steps:
# needs fetch-depth because the packaging dem reads old git tags
- name: Checkout current PR
uses: actions/checkout@v5
with:
fetch-depth: 0
- name: Install Ruby version 3.3
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3
bundler-cache: true
- name: Validate code
run: |
bundle exec rake rubocop
bundle exec rake -T | grep vox:build
bundle exec rake -T | grep vox:promote
bundle exec rake -T | grep vox:upload
working-directory: packaging

tests:
if: always()
needs:
- checks
- rspec_tests
- rake_checks
runs-on: ubuntu-24.04
name: Test suite
steps:
Expand Down
8 changes: 4 additions & 4 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ namespace :pl_ci do
task :gem_build, [:gemspec] do |t, args|
args.with_defaults(gemspec: 'openvox.gemspec')
stdout, stderr, status = Open3.capture3(<<~END)
gem build #{args.gemspec} --platform x86-mingw32 && \
gem build #{args.gemspec} --platform x64-mingw32 && \
gem build #{args.gemspec} --platform universal-darwin && \
gem build #{args.gemspec}
gem build #{args.gemspec} --verbose --strict --platform x86-mingw32 && \
gem build #{args.gemspec} --verbose --strict --platform x64-mingw32 && \
gem build #{args.gemspec} --verbose --strict --platform universal-darwin && \
gem build #{args.gemspec} --verbose --strict
END
if !status.exitstatus.zero?
puts "Error building #{args.gemspec}\n#{stdout} \n#{stderr}"
Expand Down