Generate human-readable ChangeLog #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
changed the title
Only keep a single copy of the version string to avoid forgetting to update it in one place when we bump it.
In the Vox Pupuli tradition, use labels in GitHub issues to generate a human readable changelog when we release a new version of the code.
Some parts of CI run with a bundle without the packaging gems, we should not raise an error if the github_changelog_generator gem is not found, but rather tell how to fix that when the task is called.
bastelfreak
approved these changes
May 30, 2025
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 7.x
git worktree add -d .worktree/backport-82-to-7.x origin/7.x
cd .worktree/backport-82-to-7.x
git checkout -b backport-82-to-7.x
ancref=$(git merge-base 6802054072985a40f8cbbd5aff5017d8948c9cd9 5890be87fd413c8b8be19f7cf92431510ee953ee)
git cherry-pick -x $ancref..5890be87fd413c8b8be19f7cf92431510ee953ee |
nmburgan
pushed a commit
that referenced
this pull request
Sep 5, 2025
Rename facter leftovers to openfact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Vox Pupuli tradition, use labels in GitHub issues to generate a human readable changelog when we release a new version of the code.
Also create a release page, and attach the gem to it.
I really like the way puppetlabs ci has a release preparation action that set version and update the changelog to allow a review. This is more work that what I can afford ATM, but we can go in that direction in the future.