Skip to content

Conversation

@smortex
Copy link
Member

@smortex smortex commented May 30, 2025

No description provided.

@smortex smortex added the skip-changelog Excluded from CHANGELOG label May 30, 2025
@bastelfreak
Copy link
Contributor

We updated some gem constraints to allow newer version, like #77. I'm a bit unsure if we should include those or not in the changelog.

@bastelfreak
Copy link
Contributor

speaking about it, I also just merged #52

@smortex
Copy link
Member Author

smortex commented May 30, 2025

Should these affect end-users? I trend to trim what is visible in the changelog to what affect end users and remove anything that is "internal" or "implementation detail".

It looks like the configuration we have for CHANGELOG.md and the release is not 1-1 matching, as PRs labelled "dependencies" will now appear in the latter after #83.

@bastelfreak
Copy link
Contributor

That's why I'm unsure :D I makes a difference for all the more techy users, like us, because the whole gem dependencies are now more relaxed and it's now possible to install other tools from the ecosystem. But I don't mind it if we keep it out of the changelog, I just wanted to mention it.

Also I'm not sure if the whole vanagon tooling will create the git tag in the puppet repo, or if we should/could create it 🤔

@smortex
Copy link
Member Author

smortex commented May 30, 2025

That's why I'm unsure :D I makes a difference for all the more techy users, like us, because the whole gem dependencies are now more relaxed and it's now possible to install other tools from the ecosystem. But I don't mind it if we keep it out of the changelog, I just wanted to mention it.

If we change our mind, we can relabel PRs and on next release the ChangeLog will be updated with the new content, so I think is is not a major issue and we may have some feedback to decide what to do exactly?

Also I'm not sure if the whole vanagon tooling will create the git tag in the puppet repo, or if we should/could create it 🤔

My understanding is that you release a new tag, and point to it in the right place (the commit since a tag can be changed, e.g. https://github.com/OpenVoxProject/openvox-agent/blob/a28a93c53ca617b0a0ce75a5a3ae91d1f5c1bf50/configs/components/puppet.json#L1) before moving on with building the package.

@smortex smortex merged commit f5289a1 into main May 30, 2025
10 of 14 checks passed
@smortex smortex deleted the release-8.19.0 branch May 30, 2025 17:57
nmburgan pushed a commit that referenced this pull request Sep 5, 2025
Rename puppet leftovers to openvox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Excluded from CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants