-
Notifications
You must be signed in to change notification settings - Fork 6
Add postgresql 18 testing #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postgresql 18 testing #83
Conversation
The core+ext tests do not use any Ruby code, so testing multiple Ruby versions doesn't increase test coverage.
|
@austb thanks for the PR. Do you know a bit about the int vs core+ext test suites? I tried to understand the original matrix that Perforce used, but it's all a bit confusing. Should we add pg18 to int as well? |
Yeah probably good to add it there too. Will do. |
These tests `bundle exec` the agent so it makes sense to tests them across a few Ruby versions
50c1173 to
c3d9bd7
Compare
|
The test matrix looks reasonable to me now. I had one question about the integration test set, but probably best to handle that separately so I opened #84 |
dhollinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. Nothing crazy stands out and any other concerns I may have had were already answered in existing threads
No description provided.