Skip to content

Conversation

@austb
Copy link
Contributor

@austb austb commented Nov 1, 2025

No description provided.

The core+ext tests do not use any Ruby code, so testing multiple Ruby
versions doesn't increase test coverage.
@bastelfreak bastelfreak self-assigned this Nov 1, 2025
@bastelfreak bastelfreak added the enhancement New feature or request label Nov 1, 2025
@bastelfreak
Copy link
Contributor

@austb thanks for the PR. Do you know a bit about the int vs core+ext test suites? I tried to understand the original matrix that Perforce used, but it's all a bit confusing. Should we add pg18 to int as well?

@austb
Copy link
Contributor Author

austb commented Nov 1, 2025

Do you know a bit about the int vs core+ext test suites? I tried to understand the original matrix that Perforce used, but it's all a bit confusing.

core tests reference the basic lein tests of OpenVoxDB, so just testing the Clojure code.

ext reference these tests which actually build a JAR and test the behavior of that JAR. Typically, you'd find these types of tests written as Beaker acceptance tests, but for various reasons (mostly someone didn't want to be on the VPN...) it was done in these tests instead.

integration tests are just that. Testing the integration of the DB, Server, and Agent. They clone the repos of those other two projects and run a "full system" using these integration/ tests. There it makes sense to vary the Ruby version because the agent is run via bundle exec.

Should we add pg18 to int as well?

Yeah probably good to add it there too. Will do.

austb added 2 commits November 1, 2025 09:50
These tests `bundle exec` the agent so it makes sense to tests them
across a few Ruby versions
@austb austb force-pushed the add-postgresql-18-testing branch from 50c1173 to c3d9bd7 Compare November 1, 2025 16:50
@austb
Copy link
Contributor Author

austb commented Nov 1, 2025

The test matrix looks reasonable to me now.

I had one question about the integration test set, but probably best to handle that separately so I opened #84

Copy link

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Nothing crazy stands out and any other concerns I may have had were already answered in existing threads

@bastelfreak bastelfreak enabled auto-merge November 1, 2025 20:29
@bastelfreak bastelfreak merged commit 552e904 into OpenVoxProject:main Nov 1, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants