Solves Bug #101 #111
Merged
Solves Bug #101 #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Collaborator
|
@patrickbs96 Thanks so much! |
Collaborator
|
This has been merged into the latest beta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Curtains with firmware 3.9 are not being detected anymore (#101). While analyzing the advertisement the buffer size has to be a length of 5 otherwise the curtain is not being detected. Unfortunately, the new length of the buffer size is 6.
💡 Proposed solution
Check for a length of 5 or 6. Some users might not be using the newest firmware yet.
⚙️ Release Notes
Curtains support firmware 3.9
➕ Additional Information
Added logging capabilities during the advertisement. They can be accessed by assigning a function to
onlog. Might be useful for the developers who implement this module.Testing
Tested the curtains with firmware 3.9 by using the iobroker.switchbot-ble adapter.