Fix for #71 (SwitchBot "Contact" and "Motion") #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
This pull request relates to issue #71
The current situation is that SwitchBot "Contact" and "Motion" are not working with this module.
These models are already handled, however I have found 2 problems which prevent them from being discovered:
Both models are not discovered by the Service UUID
cba20d00224d11e69fb80002a5d5c51bbecause for both modelsperipheral.advertisement.serviceUuidsis an empty array.For both models
peripheral.advertisement.serviceDatais no array unlike the other models.💡 Proposed solution
_PRIMARY_SERVICE_UUID_LISTto an empty array (=> any service UUID)serviceDataas default value ifserviceData[0]is undefined.⚙️ Release Notes
➕ Additional Information
I also corrected some typos.
Testing
I tested the advertising data with 6 devices (1 Contact, 1 Motion, 2 Meter and 2 Bot) on the terminal.