Skip to content

Renamed roles private variables to adhere to code style. #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2018
Merged

Renamed roles private variables to adhere to code style. #1507

merged 1 commit into from
Nov 20, 2018

Conversation

@nventuro
Copy link
Contributor

@nventuro nventuro commented Nov 20, 2018

Fixes #1483

@nventuro nventuro added kind:improvement contracts Smart contract code. labels Nov 20, 2018
@nventuro nventuro requested a review from frangio November 20, 2018 17:48
@nventuro nventuro added this to the v2.1 milestone Nov 20, 2018
frangio
frangio approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nventuro nventuro merged commit bb6a24e into OpenZeppelin:master Nov 20, 2018
@nventuro nventuro deleted the roles-style branch November 20, 2018 19:03
vittominacori added a commit to vittominacori/zeppelin-solidity that referenced this pull request Nov 21, 2018
@vittominacori
Merge branch 'master' of https://github.com/vittominacori/zeppelin-so…
fd957c4 
…lidity into feature/token-recover

* 'master' of https://github.com/vittominacori/zeppelin-solidity: (98 commits)
  Renamed roles private variables to adhere to code style. (OpenZeppelin#1507)
  Remove extraneous quantity check, fixes OpenZeppelin#1454 (OpenZeppelin#1455)
  Remove redundant require statements (OpenZeppelin#1409)
  Add the step to delete the build dir to the RELEASE notes (OpenZeppelin#1467)
  add an address typecast to this per issue OpenZeppelin#1457 (OpenZeppelin#1471)
  add improvement in simpletoken example OpenZeppelin#1458 (OpenZeppelin#1473)
  SafeMath Test Coverage Improved (OpenZeppelin#1477)
  The beneficiary parameter of claimRefund is replaced with refundee (OpenZeppelin#1481)
  fix ERC20.sol#L174 and ERC20.sol#L187 should be casted to an address type. (OpenZeppelin#1470)
  Fix/add comment erc721 burnable OpenZeppelin#1464 (OpenZeppelin#1469)
  Release v2.0.0
  Release candidate v2.0.0-rc.4
  Improved some ERC721 internal shenanigans (OpenZeppelin#1450)
  Add warning about trading tokens before refundable crowdsale goal is met (OpenZeppelin#1452)
  Crowdsale.buyTokens is now nonReentrant. (OpenZeppelin#1438)
  InitialRate must be strictly larger than finalRate. (OpenZeppelin#1441)
  Fixed how allowance crowdsale checks remaining tokens. (OpenZeppelin#1449)
  Deleted unnecessary import. (OpenZeppelin#1437)
  Made SampleCrowdsale a bit clearer. (OpenZeppelin#1448)
  Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. (OpenZeppelin#1447)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frangio frangio frangio approved these changes

Assignees

No one assigned

Labels

contracts Smart contract code.

Projects

None yet

Milestone

v2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@nventuro @frangio