Added time helper tests. #1521
Added time helper tests. #1521
Conversation
test/helpers/test/time.test.js
Outdated
| await time.increase(time.duration.hours(1)); | ||
|
|
||
| const end = this.start + time.duration.hours(1); | ||
| (await time.latest()).should.be.within(end - 20, end + 20); // +-20 sec tolerance |
There was a problem hiding this comment.
We can use closeTo. Can we define the tolerance in a file-wide constant?
Also, I'm curious, experimentally, what did you find the actual time increase to be?
There was a problem hiding this comment.
Didn't know about closeTo, thanks!
The time tolerance comes from the last block (and therefore the timestamp) being mined in the previous test, and the time between tests is variable (in particular, the time between ganache being set-up and the first test running may be very large).
I ended up making this more explicit by adding an advanceBlock call before calling latest(), but we should make sure the documentation explains this behavior properly.
test/helpers/test/time.test.js
Outdated
|
|
||
| describe('increaseTo', function () { | ||
| it('increases time to a time in the future', async function () { | ||
| await time.increaseTo(this.start + time.duration.hours(1)); |
There was a problem hiding this comment.
Why not use the end variable defined below?
There was a problem hiding this comment.
Because it seems I'm not very smart 😅
2 participants
Part of #1078.