pre-hactober preptember work

Author: AllenAnthes

README.md

@@ -80,6 +80,15 @@ to login to the new workspace, make sure you go ahead and do that.
 If you're having a hard time figuring this out, try checking out the following
 Slack article [Create a Slack Workspace](https://slack.com/intl/en-ca/help/articles/206845317-Create-a-Slack-workspace).
 
+#### Create expected channels
+Several of Pybot's features involve sending messages to specific channels - in order
+for this to work in your personal Slack workspace you'll need to create the following channels:
+- mentors-internal
+- greetings
+- moderators
+- oc-tech
+
+
 ### 2 - Create a pybot App in Your Slack Workspace
 
 The next step is to create a new bot application in your workspace. While still
@@ -91,6 +100,14 @@ following this, follow the guidelines for creating a bot app as laid out in the
 you get to the stage of creating the bot user, make sure to write down the bot
 user OAuth access token that is presented, as you'll need to use it later.
 
+On the `OAuth & Permissions` page configure the Pybot app with the following scopes
+
+- channels:manage
+- chat:write
+- chat:write.public
+- commands
+- users:read
+
 ### 3 - Launch pybot Locally, Passing in Your Signing Secret
 
 With your Slack workspace, app and bot user created, and your app signing secret
@@ -108,7 +125,7 @@ Here's an example of configuring these through the _pybot.env_ file:
 
 ```bash
 SLACK_BOT_SIGNING_SECRET=APP-SIGNING-SECRET
-BOT_OATH_TOKEN=BOT-USER-OAUTH-TOKEN
+BOT_USER_OAUTH_ACCESS_TOKEN=BOT-USER-OAUTH-TOKEN
 ```
 
 **NOTE**: More configuration settings than these may be specified. Please see
@@ -118,24 +135,34 @@ for details on other settings that can be set.
 ### 4 - Attach Your pybot Instance to the Public Internet
 
 With an instance of pybot running, you now need to expose this instance to the
-public internet so Slack can send in API requests. You can easily utilize serveo
-for this purpose if you wish. To do so; run the following command from your UNIX
-like workstation to setup an SSH port tunnel to serveo:
+public internet so Slack can send in API requests. You can easily utilize ngrok
+for this purpose if you wish. To do so; download ngrok from https://ngrok.com/download
+and set up a tunnel like so:
 
 ```bash
-ssh -R 80:localhost:5000 serveo.net
+ngrok http 5000
 ```
 
 Pay attention to copy out the response you get and keep this command running.
 Here's an example output from the command:
 
-```text
-Forwarding HTTP traffic from https://supersecret.serveo.net
-Press g to start a GUI session and ctrl-c to quit.
+```bash
+ngrok by @inconshreveable                                                                        (Ctrl+C to quit)
+Session Status                online                                                                             
+Session Expires               7 hours, 56 minutes                                                                
+Version                       2.3.35                                                                             
+Region                        United States (us)                                                                 
+Web Interface                 http://127.0.0.1:4040                                                              
+Forwarding                    http://9d73595a7aac.ngrok.io -> http://localhost:5000                              
+Forwarding                    https://9d73595a7aac.ngrok.io -> http://localhost:5000                             
+Connections                   ttl     opn     rt1     rt5     p50     p90                                        
+                              0       1       0.00    0.00    0.00    0.00                                       
+HTTP Requests 
 ```
 
-With this done, serveo will now expose the instance of pybot running locally
-on port 5000 on port 443 via the Base-URI it returns.
+With this done, ngrok will now expose the instance of pybot running locally
+on port 5000 via the "Forwarding" address it returns.  Be sure to use the URL
+beginning with http**s**.
 
 ### 5 - Point Slack at Your Running pybot Instance
 
@@ -166,7 +193,7 @@ subscriptions. When configuring your events URI; make sure you pass in the
 Base-URI that pybot is listening on followed by the text _/slack/events_. For
 example:
 
-    https://supersecret.serveo.net/slack/events
+    https://123_random_code_321.ngrok.io/slack/events
 
 #### Slash Commands
 
@@ -176,7 +203,7 @@ page on Slack to setup pybot slash commands. When configuring a Slash command,
 make sure you configure the request URL to match the Base-URI that pybot is
 listening on followed by the text _/slack/commands_. For example:
 
-    https://supersecret.serveo.net/slack/commands
+    https://123_random_code_321.ngrok.io/slack/commands
 
 You'll use the same URI for each command. Here's a table listing of currently
 supported commands along with some suggested configuration text:
@@ -191,6 +218,16 @@ Command | Description | Usage Hint
 /roll | roll x dice with y sides | <XdY>
 /ticket | submit ticket to admins | (text of ticket)
 
+
+**👋 IMPORTANT!**
+
+The `/lunch` command requires a valid Yelp API token stored in the `YELP_TOKEN` 
+environment variable. See https://www.yelp.com/developers/faq
+
+Similarly, the `/mentor` and `/mentor-volunteer` commands require access to an Airtable
+environment with a specific configuration.  If you're planning on working with the mentor
+functionality please reach out to the `#oc-python-projects` channel for help getting set up.  
+
 #### Interactive Components
 
 You can follow the instructions (and read helpful related information) on the
@@ -199,7 +236,7 @@ page on Slack to setup Slack interactive component configuration. When
 configuring the request URL, you'll want to set it to the Base-URI that pybot
 is listening on followed by the text _/slack/actions_. For example:
 
-    https://supersecret.serveo.net/slack/actions
+    https://123_random_code_321.ngrok.io/slack/actions
 
 You'll also want to make sure to configure the report message action with the
 following parameters:
@@ -218,8 +255,7 @@ list with more details via a PR:
 Name | Description | Example
 ---- | ----------- | -------
 SLACK_BOT_SIGNING_SECRET | The unique signing secret used by Slack for a specific app that will be validated by pybot when inspecting an inbound API request | f3b4d774b79e0fb55af624c3f376d5b4
-BOT_OATH_TOKEN | The bot user specific OAuth token used to authenticate the bot when making API requests to Slack | xoxb-800506043194-810119867738-vRvgSc3rslDUgQakFbMy3wAt
-MENTOR_CHANNEL | Slack unique identifier (not the same as the channel name) for a workspace channel that mentors should be added to | G1DRT62UC
+BOT_USER_OAUTH_ACCESS_TOKEN | The bot user specific OAuth token used to authenticate the bot when making API requests to Slack | xoxb-800506043194-810119867738-vRvgSc3rslDUgQakFbMy3wAt
 
 ## License
 This package is available as open source under the terms of the [MIT License](http://opensource.org/licenses/MIT).

docker/example.env

@@ -1,13 +1,8 @@
 # --------------------------- #
 ### pybot.env ###
 
-# BOT_OAUTH_TOKEN=<Bot User OAuth Access Token>
 # SLACK_BOT_SIGNING_SECRET=<Client Secret>
-# VERIFICATION_TOKEN=<Verification Token>
-# SLACK_BOT_ID=<Not necessary in many cases, see the below warning>
-
-##~~  "`SLACK_BOT_USER_ID` not set. It is required for `on mention` routing and discarding "
-##~~                "message coming from Sir Bot-a-lot to avoid loops."
+# BOT_USER_OAUTH_ACCESS_TOKEN=<Bot User OAuth Access Token>
 
 
 #~~ These are only needed if you want to override the default channel names ~~#

pybot/__main__.py

@@ -42,7 +42,7 @@
     bot.load_plugin(slack)
 
     admin_configs = dict(**slack_configs)
-    admin_token = os.environ.get("APP_ADMIN_OAUTH_TOKEN")
+    admin_token = os.environ.get("APP_ADMIN_OAUTH_TOKEN", "FAKE_ADMIN_TOKEN")
     if admin_token:
         admin_configs["token"] = admin_token
     admin_slack = SlackPlugin(**admin_configs)

pybot/endpoints/slack/actions/mentor_request.py

@@ -45,7 +45,7 @@ async def mentor_details_submit(action: Action, app: SirBot):
     ts = state["ts"]
     search = {"inclusive": True, "channel": channel, "oldest": ts, "latest": ts}
 
-    history = await slack.query(methods.IM_HISTORY, search)
+    history = await slack.query(methods.CONVERSATIONS_HISTORY, search)
     request["message"] = history["messages"][0]
     request.details = action["submission"]["details"]
 
@@ -56,7 +56,10 @@ async def open_details_dialog(action: Action, app: SirBot):
     request = MentorRequest(action)
     cur_details = request.details
     trigger_id = action["trigger_id"]
-    response = {"trigger_id": trigger_id, "dialog": mentor_details_dialog(action, cur_details)}
+    response = {
+        "trigger_id": trigger_id,
+        "dialog": mentor_details_dialog(action, cur_details),
+    }
     await app.plugins["slack"].api.query(methods.DIALOG_OPEN, response)
 
 

pybot/endpoints/slack/utils/__init__.py

@@ -1,10 +1,15 @@
 import os
 
-MENTOR_CHANNEL = os.environ.get("MENTOR_CHANNEL") or "mentors-internal"
-COMMUNITY_CHANNEL = os.environ.get("COMMUNITY_CHANNEL") or "greetings"
-MODERATOR_CHANNEL = os.environ.get("MODERATOR_CHANNEL") or "moderators"
-TICKET_CHANNEL = os.environ.get("TICKET_CHANNEL") or "oc-project-leads"
-YELP_TOKEN = os.environ.get("YELP_TOKEN") or "token"
+BOT_USER_OAUTH_ACCESS_TOKEN = os.environ.get("BOT_USER_OAUTH_ACCESS_TOKEN")
+BOT_OAUTH_TOKEN = os.environ.get("BOT_OAUTH_TOKEN")
+BOT_OATH_TOKEN = os.environ.get("BOT_OATH_TOKEN")
+MENTOR_CHANNEL = os.environ.get("MENTOR_CHANNEL", "mentors-internal")
+COMMUNITY_CHANNEL = os.environ.get("COMMUNITY_CHANNEL", "greetings")
+MODERATOR_CHANNEL = os.environ.get("MODERATOR_CHANNEL", "moderators")
+TICKET_CHANNEL = os.environ.get("TICKET_CHANNEL", "oc-tech")
+SLACK_BOT_USER_ID = os.environ.get("SLACK_BOT_USER_ID", "ABC123")
+SLACK_BOT_ID = os.environ.get("SLACK_BOT_ID", "ABC123")
+YELP_TOKEN = os.environ.get("YELP_TOKEN", "token")
 PORT = os.environ.get("SIRBOT_PORT", 5000)
 HOST = os.environ.get("SIRBOT_ADDR", "0.0.0.0")
 PYBOT_ENV = os.environ.get("PYBOT_ENV", "dev")
@@ -15,12 +20,11 @@
 BOT_URL = "https://github.com/OperationCode/operationcode-pybot"
 
 slack_configs = {
-    "token": os.environ.get(
-        "BOT_OAUTH_TOKEN",
-        os.environ.get('BOT_OATH_TOKEN')  # fallback using old typo value
-    ),
+    "token": BOT_USER_OAUTH_ACCESS_TOKEN
+    or BOT_OAUTH_TOKEN
+    or BOT_OATH_TOKEN,  # fallback for old values
     "signing_secret": os.environ.get("SLACK_BOT_SIGNING_SECRET"),
     "verify": os.environ.get("VERIFICATION_TOKEN"),
-    "bot_id": os.environ.get("SLACK_BOT_ID"),
-    "bot_user_id": os.environ.get("SLACK_BOT_USER_ID"),
+    "bot_id": SLACK_BOT_ID,
+    "bot_user_id": SLACK_BOT_USER_ID,
 }

pybot/endpoints/slack/utils/action_messages.py

@@ -269,7 +269,7 @@ def mentor_details_dialog(action, cur_details):
                 "name": "details",
                 "placeholder": "",
                 "required": False,
-                "value": cur_details
+                "value": cur_details,
             }
         ],
     }