Fix off by 1 in /roll

LivingInSyn · web-flow · commit 31570026934d · 2020-10-07T15:39:35.000-04:00
/roll misused randint and suffered from a possible off by 1
diff --git a/pybot/endpoints/slack/commands.py b/pybot/endpoints/slack/commands.py
@@ -150,7 +150,7 @@ async def slash_roll(command: Command, app: SirBot):
         )
         return await slack.query(methods.CHAT_POST_EPHEMERAL, response)
 
-    dice = [random.randint(1, typedice + 1) for _ in range(numdice)]
+    dice = [random.randint(1, typedice) for _ in range(numdice)]
     message = f"<@{slack_id}> Rolled {numdice} D{typedice}: {dice}"
     response = dict(channel=channel_id, text=message)
     await slack.query(methods.CHAT_POST_MESSAGE, response)

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ async def slash_roll(command: Command, app: SirBot):`
`150`	`150`	`)`
`151`	`151`	`return await slack.query(methods.CHAT_POST_EPHEMERAL, response)`
`152`	`152`
`153`		`- dice = [random.randint(1, typedice + 1) for _ in range(numdice)]`
	`153`	`+ dice = [random.randint(1, typedice) for _ in range(numdice)]`
`154`	`154`	`message = f"<@{slack_id}> Rolled {numdice} D{typedice}: {dice}"`
`155`	`155`	`response = dict(channel=channel_id, text=message)`
`156`	`156`	`await slack.query(methods.CHAT_POST_MESSAGE, response)`