Languages/Categories should delete themselves if they no longer exist

[aaron-junot]

Suppose we have a language called CSS/Bootstrap and then someone realized that that's two languages and then changes the languages for that resource to be ["CSS","Bootstrap"] instead. What happens to the language CSS/Bootstrap? Well, it gets orphaned. It exists, but there are not resources that have that language.

I think that whenever a resource is updated and the languages attribute is one of the changes, we should check that the old languages still exist on some resource. If they do not, then we should delete the language.

Same thing with categories. If a category gets removed from the last resource with that category, then the category should be deleted as well.

[mike-lloyd03]

@aaron-suarez any problems with me assigning myself to this one?

[aaron-junot]

No problem at all. Were you there in the meeting when I was going over this one and what it's about? If not, that's fine, just ask if you have any issues.

[mike-lloyd03]

No I wasn't in the meeting but I think I got it. I'll let you know if I need any pointers.

[king-11]

@aaron-suarez is the issue resolved if not I can start working on it ?

[mike-lloyd03]

The code works as written right now but unit tests are needed to cover the new functionality.

[king-11]

ohh got it @mike-lloyd03 so if the tests are needed I can start working on it if it's alright?

[mike-lloyd03]

Go for it.

[king-11]

@mike-lloyd03 i wrote some tests but it doesn't seem to work can you have a look

def test_delete_unused_languages(module_client, module_db, fake_auth_from_oc, fake_algolia_save):
    client = module_client
    apikey = get_api_key(client)

    # Happy Path
    response = update_resource(client, apikey)
    assert (response.status_code == 200)
    assert (response.json['resource'].get('name') == "New name")

    #Initial Data
    name = "Language Test"
    url = None
    category = None
    languages = ["Java", "JS/TS"]
    paid = None
    notes = None

    response = update_resource(client,
                               apikey,
                               name,
                               url,
                               category,
                               languages,
                               paid,
                               notes)
    assert (response.status_code == 200)
    assert(response.json['resource'].get('name') == "Language Test")

    languages_response = response.json['resource'].get('languages')
    assert("Java" in languages_response)
    assert("JS/TS" in languages_response)

    languages = ["Java", "Javascript", "Typescript"]
    response = update_resource(client, apikey, name, url,
                               category, languages, paid, notes)
    assert(response.status_code == 200)

    languages_response = response.json['resource'].get('languages')
    assert("Java" in languages_response)
    assert("Javascript" in languages_response)
    assert("Typescript" in languages_response)
    assert("JS/TS" not in languages_response)

    db_languages = client.get('api/v1/languages')
    db_languages = [language.get('name') for language in db_languages.json['languages']]
    # assert(isinstance(db_languages, list))
    assert("JS/TS" not in db_languages)

It's failing on the last two assertions

[aaron-junot]

@king-11 I haven't ran your test yet, but I would expect that last test to fail because we haven't yet written the code to have the languages delete themselves if they no longer exist. Did you try this on main or on @mike-lloyd03's branch?

[mike-lloyd03]

@aaron-suarez Languages should auto-delete as well. My last commit implemented that logic.