Skip to content

feature: allow conditional creation of ServiceAccount#1

Merged
rocktavious merged 2 commits intoOpsLevel:mainfrom
wc-s:t7r/serviceaccount-conditional-creation
Aug 24, 2021
Merged

feature: allow conditional creation of ServiceAccount#1
rocktavious merged 2 commits intoOpsLevel:mainfrom
wc-s:t7r/serviceaccount-conditional-creation

Conversation

@wc-s
Copy link
Copy Markdown
Contributor

@wc-s wc-s commented Aug 24, 2021

So that the user can user their own ServiceAccount with such a values file:

serviceAccount:
  create: false
  name: my-sa

This allows the user to fine-tune the RBAC permissions, which is useful especially given the current default ClusterRole allows reading Secret objects.

@rocktavious rocktavious changed the title allow conditional creation of ServiceAccount feature: allow conditional creation of ServiceAccount Aug 24, 2021
@rocktavious
Copy link
Copy Markdown
Collaborator

@wc-s Thanks for the PR! You'll need to bump the chart version too so the auto release process doesn't fail. https://github.com/OpsLevel/helm-charts/blob/main/charts/kubernetes-sync/Chart.yaml#L4

@rocktavious rocktavious added the enhancement New feature or request label Aug 24, 2021
@rocktavious rocktavious self-requested a review August 24, 2021 17:18
@wc-s
Copy link
Copy Markdown
Contributor Author

wc-s commented Aug 24, 2021

@rocktavious understood, thanks. Done.

@rocktavious rocktavious merged commit acf77a7 into OpsLevel:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants