-
Notifications
You must be signed in to change notification settings - Fork 35
Fix GitHub links #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GitHub links #95
Conversation
…erts - Defined dark mode base styles for admonitions with consistent background, border, and text colors - Customized tip, info, caution, and danger admonitions with harmonious dark color schemes - Ensured proper styling of admonition content including paragraphs and links in dark mode - Added alert styles for both light and dark themes with distinct color palettes per alert type - Applied consistent alert content styling for text and links in all themes - Included root-level CSS variable override for alert background in dark mode - Enhanced specificity for dark mode alert content to maintain color inheritance and link decoration
|
@Nexvyn is attempting to deploy a commit to the idan lodzki's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughUpdated two GitHub repository URLs in the Docusaurus configuration and made a trivial whitespace-only edit in the custom CSS; no functional behavior or exported/public declarations were changed. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
opsimate-docs/src/css/custom.css (1)
1067-1104: Consider consolidating duplicate alert styles.The alert styles defined here (lines 1067-1104) duplicate the styles already defined at lines 974-1042. While the comment at line 1059 suggests this is for specificity, this duplication:
- Increases CSS file size unnecessarily
- Creates maintenance burden (changes must be made in two places)
- Could be consolidated using higher-specificity selectors or CSS custom properties
Consider consolidating to a single definition:
-/* ===== DARK MODE SPECIFIC OVERRIDES (if needed) ===== */ - -/* Dark mode alert background */ -[data-theme="dark"]:root { - --ifm-alert-background-color: #121212 !important; -} - -/* Alternative approach - direct styling for alerts in dark mode */ -html[data-theme="dark"] .alert, -[data-theme="dark"] .alert { - background-color: #121212 !important; - border: 1px solid #333333 !important; - color: #e6eef6 !important; -} - -/* Tip alert (Our Mission block) - Dark mode */ -html[data-theme="dark"] .alert--tip, -[data-theme="dark"] .alert--tip { - background-color: #121212 !important; - border: 1px solid #3949ab !important; /* Primary indigo color */ - color: #e3f2fd !important; -} - -/* Info alert - Dark mode */ -html[data-theme="dark"] .alert--info, -[data-theme="dark"] .alert--info { - background-color: #121212 !important; - border: 1px solid #303f9f !important; /* Indigo blue */ - color: #e3f2fd !important; -} - -/* Caution alert - Dark mode */ -html[data-theme="dark"] .alert--caution, -[data-theme="dark"] .alert--caution { - background-color: #121212 !important; - border: 1px solid #5d4037 !important; /* Brownish amber */ - color: #ffecb3 !important; -} - -/* Danger alert - Dark mode */ -html[data-theme="dark"] .alert--danger, -[data-theme="dark"] .alert--danger { - background-color: #121212 !important; - border: 1px solid #6d4c41 !important; /* Brownish red */ - color: #ffcdd2 !important; -}If the duplication was added to resolve specificity issues, please add a comment explaining why both sections are necessary.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
opsimate-docs/docusaurus.config.js(2 hunks)opsimate-docs/src/css/custom.css(1 hunks)
🔇 Additional comments (2)
opsimate-docs/docusaurus.config.js (2)
61-61: LGTM! GitHub link correctly updated.The navbar GitHub link now correctly points to the main OpsiMate repository instead of the documentation repository, aligning with the PR objectives.
137-137: LGTM! Footer GitHub link correctly updated.The footer GitHub link now correctly points to the main OpsiMate repository, maintaining consistency with the navbar change.
Issue Reference
Fixes GitHub button links to point to the main OpsiMate repository instead of the documentation repository #41
What Was Changed
Updated all GitHub links across the documentation site to point to the main OpsiMate repository (https://github.com/OpsiMate/OpsiMate) instead of the documentation repository.
Specifically updated:
Why Was It Changed
The "GitHub" button currently redirects users to the documentation repository. It should link to the main OpsiMate repository as per the bug report.
These changes ensure:
Before:
After:
Summary by CodeRabbit
Documentation
Style