Skip to content

Removed moment.js (swapped to dayjs)#54

Merged
estambakio-sc merged 7 commits intomasterfrom
issue-53-dayjs
Jun 4, 2018
Merged

Removed moment.js (swapped to dayjs)#54
estambakio-sc merged 7 commits intomasterfrom
issue-53-dayjs

Conversation

@estambakio-sc
Copy link
Copy Markdown
Contributor

@estambakio-sc estambakio-sc commented May 31, 2018

#53

Moment.js functions swapped with dayjs and @opuscapita/i18n/lib/converters/DateConverter.

Result: build size with all dependencies but react and react-dom:

  • before 942 kb
  • after 484 kb

Also updated @opuscapita/react-autocompletes to 3.0.1, which saves another 70 kb of bundle.

Final size: 414kb unminified, or 44% less size.

@estambakio-sc
Copy link
Copy Markdown
Contributor Author

Build fails on importing dependency from registry, looking into it.

@kvolkovich-sc
Copy link
Copy Markdown
Contributor

kvolkovich-sc commented May 31, 2018

Can't type year value properly in case of yyyy is the last part of dateFormat.

dates

Copy link
Copy Markdown
Contributor

@kvolkovich-sc kvolkovich-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for me.

@estambakio-sc estambakio-sc merged commit 9d2f1c8 into master Jun 4, 2018
@estambakio-sc estambakio-sc deleted the issue-53-dayjs branch June 4, 2018 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants