Skip to content

add strip options #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2017
Merged

add strip options #4

merged 2 commits into from
Jan 31, 2017

Conversation

@prabhatjhaba
Copy link

@prabhatjhaba prabhatjhaba commented Jan 31, 2017 •
edited
Loading

added strip options

@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 77.326% when pulling c50cb10 on prabhatjhaba:add_strip_options into 9f6115f on Orbitale:master.

2 similar comments
@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage decreased (-0.7%) to 77.326% when pulling c50cb10 on prabhatjhaba:add_strip_options into 9f6115f on Orbitale:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017

Coverage Status

Coverage decreased (-0.7%) to 77.326% when pulling c50cb10 on prabhatjhaba:add_strip_options into 9f6115f on Orbitale:master.

Pierstoval
Pierstoval reviewed Jan 31, 2017
View reviewed changes
CommandOptions.php Outdated
return $this;
}

}
Copy link
Member

@Pierstoval Pierstoval Jan 31, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a newline here?

@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 77.326% when pulling 7ff1208 on prabhatjhaba:add_strip_options into 9f6115f on Orbitale:master.

@Pierstoval Pierstoval merged commit 4e99158 into Orbitale:master Jan 31, 2017
@Pierstoval Pierstoval mentioned this pull request Feb 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pierstoval Pierstoval Pierstoval left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prabhatjhaba @coveralls @Pierstoval