Allow additional changes via workflow #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Jan 27, 2019
Owner
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Nice, can you add an example for a php extension and one example for a phpstan plugin to the README?
Author
|
Added the examples. |
OskarStark
reviewed
Jan 27, 2019
Author
|
I understand that this is a unwanted side effect of the change. Do you have a suggestion to work around? I think the only option is to let everyone that needs a variation on this image, push its image to docker hub. I think there is no way to do that in the work flow only when needed. We could write down the effects of extra packages. And suggest that it should only be used in prototype phase of your workflow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many projects you will need extra php extensions and phpstan plugins. The changes in this PR allow you to define 2 environment variables to customize the image without any need to publish your own image and maintain your own custom actions.
I think it is needless to have multiple forks of this very nice small setup for a working github action. The suggested changes are used in phpDocumentor/phpDocumentor#2049.