Lexer! Again :) #7
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
…o use StartCompilerConsoleUI, and remove mylib and ui implementations
# Conflicts: # lib/compiler_ui/compiler_ui_functions.cpp
… improved functionality
|
@codex review |
|
Summary
Testing
|
There was a problem hiding this comment.
Really good work out there! But I would strongly advise fixing some code style inconsistencies and making a bit purer OOP in Token class removing definitions and fields from it in some way and getting rid of TokenType. All in all, great job, especially your decision with Visitor for tokens.
|
@biqiboqi I thought about Lexer class and I found a solution that can remove circular dependency of Lexer and all Handler's implementation. Let's create a class called something like "SourceWrapper" that will provide Peek and all text-handling related methods to the handlers, and store it in the lexer object and use SourceWrapper in the Handler interface. |
…aks across lexer and token classes
… and adjust error handling
…d column tracking instead of inheritance
…f clang-format for values in big program tests
final version of lexer for tests
Lexer tests ({})
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
3 participants
This PR introduces a Lexer module for the OvumLanguage compiler, responsible for lexical analysis and tokenization of source code