Skip to content

Conversation

@p1-ra
Copy link
Collaborator

@p1-ra p1-ra commented Jun 9, 2020

All is in the title.

Allow to set the default values for ppid, stream, ttl. sctp_send will then use them if they are not specified as parameters.

It is useful for when using SCTP socket as TCP/UDP socket with a library that is not aware if its custom method sctp_send.

By overwriting its send with its sctp_send method, we could now still configure the ppid and so on.

@p1-ra p1-ra changed the title Allow to set of default values for ppid, streamid, ttl Allow to set the default values for ppid, streamid, ttl Jun 9, 2020
@p1-ra p1-ra force-pushed the feature/configurable-default-ppid-ttl-streamid-value branch from 3ab555a to 6074233 Compare June 10, 2020 08:25
@p1-ra
Copy link
Collaborator Author

p1-ra commented Jun 10, 2020

  • ppid property has been removed since it's a duplicate of the existing adaptation one
  • code have been reworked to match the used code conventions
  • some comments has been added

@p1-ra p1-ra changed the title Allow to set the default values for ppid, streamid, ttl Allow to set the default values for streamid, ttl Jun 10, 2020
@p1-bmu p1-bmu merged commit ab1e97d into P1sec:master Jun 10, 2020
@p1-bmu
Copy link
Contributor

p1-bmu commented Jun 10, 2020

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants