Improve non-greedy repeat support #641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
force-pushed
the
nongreedy_repeat
branch
from
052bd4a to
532933f
Compare
Collaborator
Author
|
I did some perf measurements and the new code has a very similar speed as the old. Code size is lower, that is the advantage. |
NWilson
approved these changes
Dec 22, 2024
Member
NWilson
left a comment
NWilson
left a comment
There was a problem hiding this comment.
Cool, it's great to have them all matching, and all avoiding code bloat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be the last patch of this work. All
[class]{a,b}+/?/nothingnow compiles[class]once. In the past a[class]+may compiled three times, which consumed a large space for some eclasses.