pcre2_config: address inconsistency with the linksize reported in non 8-bit libraries #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
reviewed
Aug 27, 2025
Member
NWilson
left a comment
NWilson
left a comment
There was a problem hiding this comment.
Great! Adding the new EFFECTIVE_LINKSIZE option seems sensible and useful, and the changes to pcre2test are good overall. I just have a few small things that could be tweaked - if you agree.
NWilson
reviewed
Aug 28, 2025
carenas
force-pushed
the
linksize
branch
3 times, most recently
from
5b4c219 to
4354559
Compare
PCRE2_CONFIG_LINKSIZE can be used to determne the linksize that the library was configured to use, but the actual size (and therefore the maximum size of patterns that can be processed) is not visible. Add PCRE2_CONFIG_EFFECTIVE_LINKSIZE to gather that value and use it in `pcre2test` for reporting `linksize`; move the logic to derive one from the other out of the API documentation and test scripts to improve maintainability and while at it enable test8 in Windows for all link sizes.
NWilson
reviewed
Aug 29, 2025
NWilson
approved these changes
Aug 29, 2025
Member
NWilson
left a comment
NWilson
left a comment
There was a problem hiding this comment.
All good! I'll merge once CI completes (just to be sure nothing's broken).
Contributor
Author
|
AFAIK the "unused" test that was removed in ec48bfc is there to make sure that the linksize part of the code in pcre2_config is not completely broken, which is a "prerequisite" to trust it later when using it in test8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pcre2testreports thelinksizethat was set at build time by all libraries, but at least in the case of the 32-bit library, it is never correct by default, or even relevant as described in pcre2build.CAVEAT: before this change; eventhough there were three (one per library, if all enabled) identical versions of this function linked with pcre2test, only the first one found was being used and that was "by design", which this changes.