Ramapcsx2 psx mode

[gregory38]

Rama initial PR with various improvements

• added Turtleli feedback. Except that I kept the C ring buffer to avoid invasive change.
• added my feeback
• reformat with clang the new files
• shuffle/squash/split/rebase all commits to keep the history nice

A quick test to ensure no-regression will be nice. Replace #1571

Edit: maybe I miss a couple of review.

[FlatOutPS2]

I just tried to boot a few PSX games with this and it doesn't boot anymore, it goes to a black screen and the PSX mode logo doesn't ever show up.

[gregory38]

Oh cool. I guess I win the right to do a diff between the 2 branches.

[gregory38]

We have some conflict between old code and new code. I think it is the main issue. I need to find which box contains my psx disk to test locally. If I'm lucky it is good now.

[FlatOutPS2]

It's working again. 👍

[gregory38]

Ok. I rebased on master. Didn't changed end of file. Use dev console to be consistent.

If everybody is happy, we could merge it.

[ramapcsx2]

Let me do a quick test. Should be done in 2.

[gregory38]

@ramapcsx2 I pushed the request fix. IRC is down on my side (so reliable)...

[ramapcsx2]

Test done and everything looks to be alright. Any other opinions? :p

[FlatOutPS2]

Tested release and debug builds and noticed no new issues or regressions.

[Sarania]

@ramapcsx2 With the latest buildbot build it doesn't work at all for me anymore even using ZeroSPU2. Did something change?

[jcdenton2k]

I'd like to know the purpose behind adding in PSOne support to a PS2 emulator? Aren't there already PSOne emulators available?

Dividing the focus of the devs towards PSOne side might delay implementation and accuracy/performance improvements on the PS2 side.

I've read the previous comments about certain early PS2 games that were released on CDs instead of DVDs and that this was initially added to improve compatibility with them, but then this is branching out into a far larger project than initially anticipated.

[refractionpcsx2]

I'd like to know the purpose behind adding in PSOne support to a PS2 emulator? Aren't there already PSOne emulators available?

The PS2 natively supports PS1 emulation, we are actually completing some more of the PS2 emulation by getting this working, we are not hindering anything in PS2 emulation, we might even fix something (unlikely, but you never know)

[jcdenton2k]

Thanks for the explanation. Having PS1 emulation built into PCSX2 will be nice for users :)

[shentino]

Yeah I think PCSX2 emulating the PS2 emulating the PS1 might do better than PCSXR :P

[refractionpcsx2]

I doubt it :p

[Farhan1379]

It simply Happents to me too that if i boot ps1 games on pcsx2 it boot up black screen.
Can you guys tell me how can i fix that issue?

[JordanTheToaster]

It simply Happents to me too that if i boot ps1 games on pcsx2 it boot up black screen. Can you guys tell me how can i fix that issue?

Please don't post on such old pull requests use the Discord if you want to ask questions.