Skip to content

Conversation

@Arceen
Copy link
Contributor

@Arceen Arceen commented Oct 22, 2023

Fixes
Fixes both Fortune card and RandomQuote headers from Issue: #43
image
image

@vercel
Copy link

vercel bot commented Oct 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
acm-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2023 1:38pm

@Ishwarendra
Copy link
Contributor

Fix the same issue for home page as well.
image

There is 1 div containing text Home which is covered by navbar.

@Ishwarendra
Copy link
Contributor

Ishwarendra commented Oct 22, 2023

@Arceen don't add margin-top to activity components. I see that you have added margin-top to fortune carrd. The navbar should take its space and all the components should be below it, even if there is 0 margin and padding.

@Arceen
Copy link
Contributor Author

Arceen commented Oct 22, 2023

@Ishwarendra So I can change the navbar component but not the activity component?

@Arceen
Copy link
Contributor Author

Arceen commented Oct 22, 2023

@Ishwarendra Can you check if there's any issue now?

Copy link
Contributor

@Ishwarendra Ishwarendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @Arceen.

@Ishwarendra Ishwarendra merged commit 0fec281 into PEC-CSS:master Oct 22, 2023
@Ishwarendra Ishwarendra linked an issue Oct 22, 2023 that may be closed by this pull request
@Arceen Arceen deleted the Arceen branch October 22, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix navbar covering text

2 participants