Added Arangodb support + updated ConfigurationOption signature

Author: Geolim4

.scrutinizer.yml

@@ -10,11 +10,7 @@
 #
 
 before_commands: 
-  - "composer install --no-dev --prefer-source"
-  - "composer require predis/predis \"~1.1.0\""
-  - "composer require mongodb/mongodb \"^1.9\""
-  - "composer require phpfastcache/phpssdb ~1.0.0\""
-  - "composer require doctrine/couchdb dev-master"
+  - "./bin/ci/scripts/install_dependencies.sh"
 build:
   nodes:
     analysis:

CHANGELOG.md

@@ -21,7 +21,8 @@
 - __Helpers__
   - Deprecated `\Phpfastcache\Helper\CacheConditionalHelper`, use `\Phpfastcache\CacheContract` instead
   - The `\Phpfastcache\CacheContract` class is now also callable directly without calling `get()` method
-- __Options__
+- __Config/Options__
+  - Updated `ConfigurationOption` which is no longer an `ArrayObject` class, therefore array-syntax is no longer available.
   - Renamed configuration entry `htaccess` to `autoHtaccessCreationEnabled` for files-based drivers.
   - Renamed `IOConfigurationOptionTrait::getHtaccess()` to `IOConfigurationOptionTrait::isAutoHtaccessCreationEnabled()`
   - Renamed `IOConfigurationOptionTrait::setHtaccess()` to `IOConfigurationOptionTrait::setAutoHtaccessCreationEnabled()`

README.md

@@ -2,7 +2,7 @@
 [![Code Climate](https://codeclimate.com/github/PHPSocialNetwork/phpfastcache/badges/gpa.svg)](https://codeclimate.com/github/PHPSocialNetwork/phpfastcache) [![Scrutinizer Code Quality](https://scrutinizer-ci.com/g/PHPSocialNetwork/phpfastcache/badges/quality-score.png?b=master)](https://scrutinizer-ci.com/g/PHPSocialNetwork/phpfastcache/?branch=master) [![Build Status](https://travis-ci.com/PHPSocialNetwork/phpfastcache.svg?branch=master)](https://travis-ci.com/PHPSocialNetwork/phpfastcache) [![Semver compliant](https://img.shields.io/badge/Semver-2.0.0-yellow.svg?maxAge=86400)](https://semver.org/spec/v2.0.0.html) [![Patreon](https://img.shields.io/badge/Support%20us%20on-Patreon-f96854.svg?maxAge=86400)](https://www.patreon.com/geolim4)
 
 #### :warning: Please note that the V9 is mostly a PHP 8 type aware update of Phpfastcache with some significant changes !
-> As the V9 is **relatively** not compatible with previous versions, please read carefully the [migration guide](./docs/migration/MigratingFromV7ToV8.md) to ensure you the smoothest migration possible.
+> As the V9 is **relatively** not compatible with previous versions, please read carefully the [migration guide](./docs/migration/MigratingFromV8ToV9.md) to ensure you the smoothest migration possible.
 One of the biggest change is the configuration system which is now an object that replace the primitive array that we used to implement back then. 
 Also, please note that the V9 requires at least PHP 8 or higher to works properly.
 
@@ -30,7 +30,7 @@ The simplicity of abstraction: One class for many backend cache. You don't need
 \* Driver descriptions available in DOCS/DRIVERS.md
 
 ---------------------------
-Because caching does not means weaken your code
+Because caching does not mean weaken your code
 ---------------------------
 Phpfastcache has been developed over the years with 3 main goals:
 

bin/ci/scripts/install_dependencies.sh

@@ -2,4 +2,4 @@
 
 composer self-update
 composer install
-composer require doctrine/couchdb:dev-master phpfastcache/phpssdb:~1.1.0 predis/predis:~1.1.0 mongodb/mongodb:^1.9
+composer require doctrine/couchdb:dev-master phpfastcache/phpssdb:~1.1.0 predis/predis:~1.1.0 mongodb/mongodb:^1.9 triagens/arangodb:^3.8

composer.json

@@ -55,7 +55,8 @@
         "predis/predis": "^1.1",
         "mongodb/mongodb": "^1.9",
         "phpfastcache/phpssdb": "~1.1.0",
-        "doctrine/couchdb": "^dev-master#9eeb9e5"
+        "doctrine/couchdb": "^dev-master#9eeb9e5",
+        "triagens/arangodb": "^3.8"
     },
     "conflict": {
         "doctrine/couchdb": "<dev-master#9eeb9e5"

docs/migration/MigratingFromV8ToV9.md

@@ -7,6 +7,15 @@ Once released, the php version 8.1 will be unit-tested
 ### Embedded autoload has been removed (and therefore, embedded dependencies)
 Use [Composer](https://getcomposer.org/doc/03-cli.md#require) to include Phpfastcache in your project
 
+### Updated `ConfigurationOption` which is no longer an `ArrayObject` class
+You can no longer use the following array-compatible syntax: `$config['yourKey'] = 'value'`\
+Use the object-notation syntax instead: `$config->setYourKey('value')`
+
+However, this syntax is STILL valid through the configuration constructor\
+For the default config object: `new ConfigurationOption(['yourKey' => 'yourValue'])`\
+Or for specific config objects: `new \Phpfastcache\Drivers\Files\Config(['yourKey' => 'yourValue'])`\
+Finally, the config name you try to set MUST be recognized or an exception will be thrown. 
+
 ### Deprecated `\Phpfastcache\Helper\CacheConditionalHelper`
 Use `\Phpfastcache\CacheContract` instead. See [Wiki](https://github.com/PHPSocialNetwork/phpfastcache/wiki/%5BV9%CB%96%5D-Cache-contract).
 

lib/Phpfastcache/CacheManager.php

@@ -147,7 +147,10 @@ public static function getInstance(string $driver, ?ConfigurationOptionInterface
 
             if (\class_exists($driverClass)) {
                 $configClass = $driverClass::getConfigClass();
-                self::$instances[$instanceId] = new $driverClass(new $configClass($config->toArray()), $instanceId);
+                if ($configClass !== $config::class) {
+                    $config = new $configClass($config->toArray());
+                }
+                self::$instances[$instanceId] = new $driverClass($config, $instanceId);
                 self::$instances[$instanceId]->setEventManager(EventManager::getInstance());
             } else {
                 throw new PhpfastcacheDriverNotFoundException(sprintf('The driver "%s" does not exists', $driver));
@@ -158,25 +161,18 @@ public static function getInstance(string $driver, ?ConfigurationOptionInterface
     }
 
     /**
-     * @param ConfigurationOptionInterface|null $config
+     * @param ConfigurationOption|null $config
      * @return ConfigurationOption
-     * @throws PhpfastcacheInvalidArgumentException
      */
-    protected static function validateConfig(?ConfigurationOptionInterface $config): ConfigurationOption
+    protected static function validateConfig(?ConfigurationOption $config): ConfigurationOption
     {
-        if ($config === null) {
-            $config = self::getDefaultConfig();
-        } elseif (!($config instanceof ConfigurationOption)) {
-            throw new PhpfastcacheInvalidArgumentException(\sprintf('Unsupported config type: %s', \gettype($config)));
-        }
-
-        return $config;
+        return $config ?? self::getDefaultConfig();
     }
 
     /**
-     * @return ConfigurationOptionInterface
+     * @return ConfigurationOption
      */
-    public static function getDefaultConfig(): ConfigurationOptionInterface
+    public static function getDefaultConfig(): ConfigurationOption
     {
         return self::$config ?? self::$config = new ConfigurationOption();
     }
@@ -282,6 +278,9 @@ static function (ExtendedCacheItemPoolInterface $cachePool) use ($cachePoolInsta
      */
     public static function setDefaultConfig(ConfigurationOption $config): void
     {
+        if(is_subclass_of($config, ConfigurationOption::class)){
+            throw new PhpfastcacheInvalidArgumentException('Default configuration cannot be a child class of ConfigurationOption::class');
+        }
         self::$config = $config;
     }
 

lib/Phpfastcache/Config/ConfigurationOption.php

@@ -17,14 +17,8 @@
 
 use Phpfastcache\Exceptions\PhpfastcacheInvalidArgumentException;
 use Phpfastcache\Exceptions\PhpfastcacheInvalidConfigurationException;
-use Phpfastcache\Util\ArrayObject;
-use ReflectionException;
-use ReflectionMethod;
-use ReflectionNamedType;
-use ReflectionParameter;
-use TypeError;
-
-class ConfigurationOption extends ArrayObject implements ConfigurationOptionInterface
+
+class ConfigurationOption implements ConfigurationOptionInterface
 {
     protected bool $itemDetailedDate = false;
 
@@ -53,36 +47,22 @@ class ConfigurationOption extends ArrayObject implements ConfigurationOptionInte
     protected ?object $superGlobalAccessor = null;
 
     /**
-     * @param $args
-     * ArrayObject constructor.
      * @throws PhpfastcacheInvalidConfigurationException
-     * @throws ReflectionException
      */
-    public function __construct(...$args)
+    public function __construct(array $parameters = [])
     {
-        parent::__construct(...$args);
-        $array =& $this->getArray();
-
-        /**
-         * Detect unwanted keys and throw an exception.
-         * No more kidding now, it's 21th century.
-         */
-        if (\array_diff_key($array, \get_object_vars($this))) {
-            throw new PhpfastcacheInvalidConfigurationException(
-                sprintf(
-                    'Invalid option(s) for the config %s: %s',
-                    static::class,
-                    \implode(', ', \array_keys(\array_diff_key($array, \get_object_vars($this))))
-                )
-            );
-        }
-
-        foreach (\get_object_vars($this) as $property => $value) {
+        foreach ($parameters as $configKey => $configVal) {
             try {
-                if (\array_key_exists($property, $array)) {
-                    $this->$property = &$array[$property];
+                if (\property_exists($this, $configKey)) {
+                    $this->{'set' . \ucfirst($configKey)}($configVal);
                 } else {
-                    $array[$property] = &$this->$property;
+                    throw new PhpfastcacheInvalidConfigurationException(
+                        sprintf(
+                            'Invalid option for the config %s: %s',
+                            $this::class,
+                            $configKey
+                        )
+                    );
                 }
             } catch (\TypeError $e) {
                 throw new PhpfastcacheInvalidConfigurationException(
@@ -93,40 +73,11 @@ public function __construct(...$args)
                 );
             }
         }
+    }
 
-        foreach (\get_class_methods($this) as $method) {
-            if (str_starts_with($method, 'set')) {
-                $value = null;
-                try {
-                    /**
-                     * We use property instead of getter
-                     * because of is/get conditions and
-                     * to allow us to retrieve the value
-                     * in catch statement bloc
-                     */
-                    $value = $this->{\lcfirst(\substr($method, 3))};
-                    $this->{$method}($value);
-                } catch (TypeError) {
-                    $typeHintGot = \get_debug_type($value);
-                    $reflectionMethod = new ReflectionMethod($this, $method);
-                    $parameter = $reflectionMethod->getParameters()[0] ?? null;
-                    $typeHintExpected = 'Unknown type';
-
-                    if ($parameter instanceof ReflectionParameter && $parameter->getType() instanceof ReflectionNamedType) {
-                        $typeHintExpected = ($parameter->getType()->getName() === 'object' ? $parameter->getType() : $parameter->getType()->getName());
-                    }
-
-                    throw new PhpfastcacheInvalidConfigurationException(
-                        \sprintf(
-                            'Invalid type hint found for "%s", expected "%s" got "%s"',
-                            \lcfirst(\substr($method, 3)),
-                            $typeHintExpected,
-                            $typeHintGot
-                        )
-                    );
-                }
-            }
-        }
+    public function toArray(): array
+    {
+        return get_object_vars($this);
     }
 
     /**

lib/Phpfastcache/Config/ConfigurationOptionInterface.php

@@ -20,10 +20,14 @@
 interface ConfigurationOptionInterface
 {
     /**
-     * @param $args
-     * ArrayObject constructor.
+     * ConfigurationOptionInterface constructor.
      */
-    public function __construct(...$args);
+    public function __construct(array $parameters = []);
+
+    /**
+     * @return array
+     */
+    public function toArray(): array;
 
     /**
      * @param string $optionName

lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php

@@ -146,7 +146,7 @@ public function getItem(string $key): ExtendedCacheItemInterface
                 }
                 $driverData = $this->driverUnwrapData($driverArray);
 
-                if ($this->getConfig()['preventCacheSlams']) {
+                if ($this->getConfig()->isPreventCacheSlams()) {
                     while ($driverData instanceof ItemBatch) {
                         if ($driverData->getItemDate()->getTimestamp() + $this->getConfig()->getCacheSlamsTimeout() < \time()) {
                             /**
@@ -208,7 +208,7 @@ public function getItem(string $key): ExtendedCacheItemInterface
                      * Reset the Item
                      */
                     $item->set(null)
-                        ->expiresAfter(abs((int)$this->getConfig()['defaultTtl']))
+                        ->expiresAfter(abs((int)$this->getConfig()->getDefaultTtl()))
                         ->setHit(false)
                         ->setTags([]);
                     if ($this->getConfig()->isItemDetailedDate()) {
@@ -224,7 +224,7 @@ public function getItem(string $key): ExtendedCacheItemInterface
                     $item->setHit(true);
                 }
             } else {
-                $item->expiresAfter(abs((int)$this->getConfig()['defaultTtl']));
+                $item->expiresAfter(abs($this->getConfig()->getDefaultTtl()));
             }
             }
         } else {